Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs batch 2 #673

Closed
1 task done
nponeccop opened this issue Apr 10, 2023 · 12 comments
Closed
1 task done

PRs batch 2 #673

nponeccop opened this issue Apr 10, 2023 · 12 comments

Comments

@nponeccop
Copy link
Contributor

nponeccop commented Apr 10, 2023

Duplicates

  • I have searched the existing issues

Summary 💡

Clean Merge Trivial 🌈

Clean Merge Not So Trivial

Now these are non-trivial PRs but having all problems resolved.

Conflicts

Question

Motivation 🔦

Well, Batch 1 was a success. This batch is ready now, and #709 is WIP

@Aopenz

This comment was marked as off-topic.

@Aopenz

This comment was marked as off-topic.

@Aopenz

This comment was marked as off-topic.

@nponeccop
Copy link
Contributor Author

@Torantulino The new batch is ready!

@nponeccop

This comment was marked as outdated.

@nponeccop

This comment was marked as outdated.

@nponeccop

This comment was marked as outdated.

@nponeccop

This comment was marked as outdated.

@nponeccop
Copy link
Contributor Author

nponeccop commented Apr 11, 2023

@Torantulino can you merge 5 more? They are clean now.

@nponeccop
Copy link
Contributor Author

nponeccop commented Apr 12, 2023

For those who have been waiting, we are going to start merging again later today. The project suffers from organizational issues and resolving them takes time. We will fix the master and probably organize a stable branch so that many people can always try the last good version and things like this debug breakage won't happen again.

(This is not an official announcement)

@nponeccop
Copy link
Contributor Author

Thank you all! The batch 2 is finally done now. We are testing it in master, and probably will merge into the new stable branch after the initial testing.

The batch 3 is still open, when we start merging the list of PRs in it will be frozen, so the new PRs will get into Batch 4. If your PR is clean but not in the batch yet, tag me I'll come to check and add.

Thanks for everyone who made it possible. @Torantulino @richbeales and pi (I don't know the GitHub username).

@p-i- p-i- mentioned this issue Apr 12, 2023
@katmai
Copy link

katmai commented Apr 13, 2023

you guys are awesome. please keep this up. you are great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants