Remove trailing whitespace throughout #712
Merged
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tymrtn
approved these changes
Apr 10, 2023
dhensen
approved these changes
Apr 10, 2023
|
That's the point of this PR. To fix the whitespace. |
|
Oh lol, I wrote that comment as part of the review... I didnt know it would end up in the normal comment section. I thought it was a comment that would be visible on my review somehow.. anyways... I approved |
Torantulino
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is a new instance of #590. After many merged PR the trailing space creeped in again.
Changes
Only space characters at EOL were trimmed, and in the edited files the ending \r\n was added automaticall by vim (which is a good thing)
Documentation
N/A
Test Plan
N/A
PR Quality Checklist