Fix JSON string escaping issue #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where double quotes were not being escaped in JSON strings, causing parse errors.
fix by converting to valid null value for JSON
consistent escaping
waynehamadi
approved these changes
Apr 4, 2023
Arlodotexe
approved these changes
Apr 4, 2023
nponeccop
approved these changes
Apr 9, 2023
richbeales
approved these changes
Apr 9, 2023
|
Resolve the conflicts. |
Torantulino
approved these changes
Apr 10, 2023
|
While this does require a benchmark for definitive proof, It looks good and I'm happy to merge it. I'm way too tired to be trusted with that merge conflict right now however, so I'll get to this in the morning. |
|
@PhilipAD There are conflicts again |
richbeales
added a commit
that referenced
this pull request
Apr 15, 2023
tgonzales
pushed a commit
to tgonzales/Auto-GPT
that referenced
this pull request
Apr 19, 2023
Say383
pushed a commit
to Say383/Auto-GPT
that referenced
this pull request
Sep 8, 2023
SquareandCompass
pushed a commit
to SquareandCompass/Auto-GPT
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where double quotes were not being escaped in JSON strings, causing parse errors.