Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning issue with Rust 2018 changes #2

Closed
SilentByte opened this issue Apr 5, 2019 · 1 comment
Closed

Versioning issue with Rust 2018 changes #2

SilentByte opened this issue Apr 5, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@SilentByte
Copy link
Owner

The release should have been a feature release, because a crate might depend on the new functionality introduced with 1.0.2 (being able to use name_of!(type ...) without importing name_of_type!).

This might be an issue in the following situation:

Given that crate A depends on crate B and the following versions:

crate Cargo.toml Cargo.lock
crate A - 1.0.1
crate B 1.0 -

When crate B uses the new feature from 1.0.2, crate A fails to build.

I recommend releasing two new versions:

  • 1.0.3 (Identical to 1.0.1)
  • 1.1.0 (Identical to 1.0.2)

Also 1.0.2 should be yanked from crates.io.


Co-written-by: @bash

Originally posted by @jeremystucki in #1 (comment)

@SilentByte SilentByte changed the title The release should have been a feature release, because a crate might depend on the new functionality introduced with 1.0.2 (being able to use name_of!(type ...) without importing name_of_type!). Versioning issue with Rust 2018 changes Apr 5, 2019
@SilentByte SilentByte added the bug Something isn't working label Apr 5, 2019
SilentByte added a commit that referenced this issue May 29, 2019
@SilentByte
Copy link
Owner Author

Should be fixed now, thanks again for the advice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant