Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36: Send 0xFF by default for endpoint_find controllable with a flag #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

silabs-borisl
Copy link
Collaborator

@silabs-borisl silabs-borisl commented Mar 12, 2024

A new flag have been introduced to send the endpoint Generic/Specific class in multi_channel_endpoint_find to support legacy device.

This should fix the regression introduced with Unify 1.5 : The default behavior is to send 0xFF to discover all endpoints.

Forwarded: #37
Bug-SiliconLabs: UIC-3160
Bug-Github: #37

… with a flag

A new flag have been introduced to send the endpoint Generic/Specific class in multi_channel_endpoint_find.

The default behavior is to send 0xFF to discover all endpoints.

Forwarded: SiliconLabs#36
Bug-SiliconLabs: UIC-3160
Bug-Github: SiliconLabs#36
@sohail-shareef
Copy link

After updating this fix to 1.5.0 SDK we are getting the generic and specific type from the ZPC.
It is working fine.

@rzr
Copy link
Collaborator

rzr commented Apr 19, 2024

LGTM I will test it until approve

Feel free to also pick this change to trigger tests:

#42

@rzr
Copy link
Collaborator

rzr commented May 21, 2024

So let's make sure UIC-3160 is part of our next release (track git describe here)

Cc: @silabs-borisl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants