Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made a bookmarkbutton component #75

Merged
merged 3 commits into from
Dec 12, 2023
Merged

made a bookmarkbutton component #75

merged 3 commits into from
Dec 12, 2023

Conversation

leonbjorklund
Copy link
Collaborator

No description provided.

@leonbjorklund leonbjorklund linked an issue Dec 12, 2023 that may be closed by this pull request
create a bookmark-button component #62
Closed
ellensofia
ellensofia requested changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@ellensofia ellensofia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Så mycket bättre att separera den. :) Tror dock inte att bookmark bör ligga i MovieCard mappen eftersom att den används utanför. Föreslår att vi skapar en egen mapp och styling fil för bookmark.

ellensofia
ellensofia approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@ellensofia ellensofia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toppen!!

@ellensofia ellensofia merged commit e01102f into main Dec 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellensofia ellensofia ellensofia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create a bookmark-button component
2 participants
@leonbjorklund @ellensofia