Saving Settings and Reload Script #130
Conversation
Merge from Master
Merge from master
Merge from master
Merge from master
PROShine/Views/MainWindow.xaml.cs
Outdated
|
|
||
| if (!string.IsNullOrEmpty(UserSettings.LastScript)) | ||
| { | ||
| MenuReloadScript.Header = "Reload " + Path.GetFileName(UserSettings.LastScript) + "\tCtrl+R"; |
There was a problem hiding this comment.
You can probably use InputGestureText="Ctrl+R" in the XAML instead of adding the string manually.
There was a problem hiding this comment.
Cool, I didn't know about that.
PROBot/UserSettings.cs
Outdated
|
|
||
| namespace PROBot | ||
| { | ||
| public static class UserSettings |
There was a problem hiding this comment.
The class doesn't need to be static, you can instantiate it in BotClient or in the view.
That way we can instantiate multiple clients with different settings if we want to.
| string fileText = File.ReadAllText("Settings.json"); | ||
| JObject json = JsonConvert.DeserializeObject(fileText) as JObject; | ||
| _settings = JsonConvert.DeserializeObject<SettingsCache>(json.ToString()); | ||
| return; |
There was a problem hiding this comment.
You can remove the return here and move _settings = new SettingsCache(); inside the catch {}
There was a problem hiding this comment.
It needs to create a new setting if the file does not exist, that's why I did it that way.
There was a problem hiding this comment.
If you move the new settings creation inside the catch, the behaviour stays the same:
// ...
catch
{
_settings = new SettingsCache();
}There was a problem hiding this comment.
If you delete the Settings file and try it again, you'll see that _settings will be null if you do that.
There was a problem hiding this comment.
Oh, indeed, I forgot about the if. We can keep it like this then.
|
I added some comments, but it looks good overall. 👍 |
No description provided.