Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #12584 #754

Closed
wants to merge 1 commit into from
Closed

Feature #12584 #754

wants to merge 1 commit into from

Conversation

mmoqui
Copy link
Member

@mmoqui mmoqui commented Sep 23, 2021

Take into account the artifact silverpeas-core-web is splitted in two:

  • silverpeas-core-rs
  • and silverpeas-core-web

Don't forget to merge before Silverpeas/Silverpeas-Core#1164 and then, after this one, Silverpeas/Silverpeas-Assembly#19

Take into account the module silverpeas-core-web is splitted in two:
- silverpeas-core-rs
- and silverpeas-core-web

Take into account in the Jenkinsfile build descriptor the property
core.version in the pom.xml is valued with a string and no more through
a reference to the project version. Indeed, when some Silverpeas
components are a dependency of an external project with its own
versionning, the project.version property is then the one of the
external project and not the one of Silverpeas-Components: it is a
dynamic property.
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@SilverYoCha SilverYoCha self-assigned this Oct 5, 2021
Copy link
Member

@SilverYoCha SilverYoCha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small feedbacks

@SilverYoCha
Copy link
Member

Merged.
Closed manually because of manual git operations performed during integration.

@mmoqui mmoqui deleted the feature-12584 branch January 20, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants