Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 12584 #1164

Closed
wants to merge 2 commits into from
Closed

Feature 12584 #1164

wants to merge 2 commits into from

Conversation

mmoqui
Copy link
Member

@mmoqui mmoqui commented Sep 23, 2021

Split the module core-web into modules:

  • core-rs with the API to make REST web services,
  • core-web with the rest

WarBuilder in core-test takes into account now the adding as Maven dependency of a project library that has its own versioning policy.

Don't forget to merge after Silverpeas/Silverpeas-Components#754 and Silverpeas/Silverpeas-Assembly#19

Copy link
Member

@SilverYoCha SilverYoCha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small feedbacks

Split module silverpeas-core-web in two modules:
- silverpeas-core-rs that provides the API to build REST-based web
services in Silverpeas,
- silverpeas-core-web that provides both the MVC framework to build web
GUI components and the core REST-based services above some of the core
business objects of Silverpeas

A mapper of the javax-rs WebApplicationException exception is added to
circumvent the one in commons-jaxrs. It extends the commons-jaxrs
WebApplicationExceptionMapper.
Update WarBuilder so that it is possible to add or to create a Maven
dependency a project library other than a Silverpeas one and with a
version that follows a life-cycle different than the one of Silverpeas.
Copy link
Member

@SilverYoCha SilverYoCha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@SilverYoCha
Copy link
Member

Merged.
Closed manually because of manual git operations performed during integration.

@mmoqui mmoqui deleted the feature-12584 branch October 18, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants