New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 12584 #1164
Closed
Closed
Feature 12584 #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2021
mmoqui
force-pushed
the
feature-12584
branch
3 times, most recently
from
September 27, 2021 16:30
c3713bd
to
43836e6
Compare
SilverYoCha
reviewed
Oct 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small feedbacks
core-rs/src/main/java/org/silverpeas/core/web/token/SynchronizerTokenService.java
Outdated
Show resolved
Hide resolved
...on-test/java/org/silverpeas/core/questioncontainer/container/dao/QuestionContainerDAOIT.java
Outdated
Show resolved
Hide resolved
...ncontainer/src/main/java/org/silverpeas/core/questioncontainer/question/dao/QuestionDAO.java
Outdated
Show resolved
Hide resolved
core-war/src/main/webapp/personalizationPeas/jsp/checkPersonalization.jsp
Outdated
Show resolved
Hide resolved
core-war/src/main/webapp/socialNetwork/jsp/myProfil/myProfileTabIdentity.jsp
Outdated
Show resolved
Hide resolved
core-war/src/main/webapp/socialNetwork/jsp/myProfil/myProfileTabIdentity.jsp
Outdated
Show resolved
Hide resolved
Split module silverpeas-core-web in two modules: - silverpeas-core-rs that provides the API to build REST-based web services in Silverpeas, - silverpeas-core-web that provides both the MVC framework to build web GUI components and the core REST-based services above some of the core business objects of Silverpeas A mapper of the javax-rs WebApplicationException exception is added to circumvent the one in commons-jaxrs. It extends the commons-jaxrs WebApplicationExceptionMapper.
Update WarBuilder so that it is possible to add or to create a Maven dependency a project library other than a Silverpeas one and with a version that follows a life-cycle different than the one of Silverpeas.
SilverYoCha
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the module core-web into modules:
WarBuilder in core-test takes into account now the adding as Maven dependency of a project library that has its own versioning policy.
Don't forget to merge after Silverpeas/Silverpeas-Components#754 and Silverpeas/Silverpeas-Assembly#19