Skip to content

Commit

Permalink
150112 Sensitive form field has not disabled autocomplete
Browse files Browse the repository at this point in the history
  • Loading branch information
SilverYoCha committed Mar 29, 2019
1 parent ac7cc3a commit 7efd360
Show file tree
Hide file tree
Showing 13 changed files with 26 additions and 26 deletions.
2 changes: 1 addition & 1 deletion core-war/src/main/webapp/agenda/jsp/synchroIcal.jsp
Expand Up @@ -126,7 +126,7 @@ function synchroIcal() {
<span class="txtlibform"><%=resources.getString("agenda.SynchroRemotePwd")%></span>
</td>
<td>
<input maxlength="50" size="50" type="password" autocomplete="false" name="PwdIcalendar" value="<%=pwdIcalendar%>"/>
<input maxlength="50" size="50" type="password" autocomplete="off" name="PwdIcalendar" value="<%=pwdIcalendar%>"/>
</td>
</tr>
<tr>
Expand Down
6 changes: 3 additions & 3 deletions core-war/src/main/webapp/defaultChangePassword.jsp
Expand Up @@ -100,15 +100,15 @@
<div class="clear"></div>
</div>
<p>
<label><span><fmt:message key="authentication.password.old" bundle="${authenticationBundle}"/></span><input type="password" name="oldPassword" id="oldPassword" autocomplete="false"/></label>
<label><span><fmt:message key="authentication.password.old" bundle="${authenticationBundle}"/></span><input type="password" name="oldPassword" id="oldPassword" autocomplete="off"/></label>
</p>

<p>
<label><span><fmt:message key="authentication.password.new" bundle="${authenticationBundle}"/></span><input type="password" name="newPassword" id="newPassword" autocomplete="false"/></label>
<label><span><fmt:message key="authentication.password.new" bundle="${authenticationBundle}"/></span><input type="password" name="newPassword" id="newPassword" autocomplete="off"/></label>
</p>

<p>
<label><span><fmt:message key="authentication.password.confirm" bundle="${authenticationBundle}"/></span><input type="password" name="confirmPassword" id="confirmPassword" autocomplete="false"/></label>
<label><span><fmt:message key="authentication.password.confirm" bundle="${authenticationBundle}"/></span><input type="password" name="confirmPassword" id="confirmPassword" autocomplete="off"/></label>
</p>
<c:if test="${isEmailAddress}">
<p>
Expand Down
6 changes: 3 additions & 3 deletions core-war/src/main/webapp/defaultForcePasswordChange.jsp
Expand Up @@ -85,15 +85,15 @@
<div class="clear"></div>
</div>
<p><label><span><%=authenticationBundle.getString(
"authentication.password.old") %></span><input type="password" autocomplete="false" name="oldPassword" id="oldPassword"/></label>
"authentication.password.old") %></span><input type="password" autocomplete="off" name="oldPassword" id="oldPassword"/></label>
</p>

<p><label><span><%=authenticationBundle.getString(
"authentication.password.new") %> </span><input type="password" autocomplete="false" name="newPassword" id="newPassword"/></label>
"authentication.password.new") %> </span><input type="password" autocomplete="off" name="newPassword" id="newPassword"/></label>
</p>

<p><label><span><%=authenticationBundle.getString(
"authentication.password.confirm") %></span><input type="password" autocomplete="false" name="confirmPassword" id="confirmPassword"/></label>
"authentication.password.confirm") %></span><input type="password" autocomplete="off" name="confirmPassword" id="confirmPassword"/></label>
</p>

<div class="submit">
Expand Down
2 changes: 1 addition & 1 deletion core-war/src/main/webapp/defaultLogin.jsp
Expand Up @@ -209,7 +209,7 @@
</p>

<p>
<label><span><fmt:message key="authentication.logon.password"/></span><input type="password" name="Password" id="Password" autocomplete="false"/></label>
<label><span><fmt:message key="authentication.logon.password"/></span><input type="password" name="Password" id="Password" autocomplete="off"/></label>
</p>
<c:choose>
<c:when test="${!pageScope.multipleDomains}">
Expand Down
2 changes: 1 addition & 1 deletion core-war/src/main/webapp/defaultLoginQuestion.jsp
Expand Up @@ -101,7 +101,7 @@
<div class="clear"></div>
</div>
<p><label><span><%=userDetail.getLoginQuestion()%></span>
<input type="password" autocomplete="false" name="answer" id="answer"/></label></p>
<input type="password" autocomplete="off" name="answer" id="answer"/></label></p>

<div class="submit">
<p>
Expand Down
4 changes: 2 additions & 2 deletions core-war/src/main/webapp/defaultLoginQuestionSelection.jsp
Expand Up @@ -116,11 +116,11 @@
<br/><br/>

<p><label><span><%=authenticationBundle.getString(
"authentication.reminder.answer") %></span><input type="password" autocomplete="false" name="answer" id="answer"/></label>
"authentication.reminder.answer") %></span><input type="password" autocomplete="off" name="answer" id="answer"/></label>
</p>

<p><label><span><%=authenticationBundle.getString(
"authentication.reminder.confirm") %></span><input type="password" autocomplete="false" name="answerConfirmed" id="answerConfirmed"/></label>
"authentication.reminder.confirm") %></span><input type="password" autocomplete="off" name="answerConfirmed" id="answerConfirmed"/></label>
</p>

<div class="submit">
Expand Down
6 changes: 3 additions & 3 deletions core-war/src/main/webapp/defaultPasswordAboutToExpire.jsp
Expand Up @@ -95,15 +95,15 @@
<div class="clear"></div>
</div>
<p><label><span><%=authenticationBundle.getString(
"authentication.password.old") %></span><input type="password" autocomplete="false" name="oldPassword" id="oldPassword"/></label>
"authentication.password.old") %></span><input type="password" autocomplete="off" name="oldPassword" id="oldPassword"/></label>
</p>

<p><label><span><%=authenticationBundle.getString(
"authentication.password.new") %></span><input type="password" autocomplete="false" name="newPassword" id="newPassword"/></label>
"authentication.password.new") %></span><input type="password" autocomplete="off" name="newPassword" id="newPassword"/></label>
</p>

<p><label><span><%=authenticationBundle.getString(
"authentication.password.confirm") %></span><input type="password" autocomplete="false" name="confirmPassword" id="confirmPassword"/></label>
"authentication.password.confirm") %></span><input type="password" autocomplete="off" name="confirmPassword" id="confirmPassword"/></label>
</p>

<div class="submit">
Expand Down
6 changes: 3 additions & 3 deletions core-war/src/main/webapp/defaultPasswordExpired.jsp
Expand Up @@ -89,15 +89,15 @@
<div class="clear"></div>
</div>
<p><label><span><%=authenticationBundle.getString(
"authentication.password.old") %></span><input type="password" autocomplete="false" name="oldPassword" id="oldPassword"/></label>
"authentication.password.old") %></span><input type="password" autocomplete="off" name="oldPassword" id="oldPassword"/></label>
</p>

<p><label><span><%=authenticationBundle.getString(
"authentication.password.new") %></span><input type="password" autocomplete="false" name="newPassword" id="newPassword"/></label>
"authentication.password.new") %></span><input type="password" autocomplete="off" name="newPassword" id="newPassword"/></label>
</p>

<p><label><span><%=authenticationBundle.getString(
"authentication.password.confirm") %></span><input type="password" autocomplete="false" name="confirmPassword" id="confirmPassword"/></label>
"authentication.password.confirm") %></span><input type="password" autocomplete="off" name="confirmPassword" id="confirmPassword"/></label>
</p>
<input type="hidden" name="login" value="${param.login}"/>
<input type="hidden" name="domainId" value="${param.domainId}"/>
Expand Down
4 changes: 2 additions & 2 deletions core-war/src/main/webapp/defaultResetPassword.jsp
Expand Up @@ -84,11 +84,11 @@
<div class="clear"></div>
</div>
<p><label><span><%=authenticationBundle.getString(
"authentication.password.new") %> </span><input type="password" autocomplete="false" name="password" id="password"/></label>
"authentication.password.new") %> </span><input type="password" autocomplete="off" name="password" id="password"/></label>
</p>

<p><label><span><%=authenticationBundle.getString(
"authentication.password.confirm") %></span><input type="password" autocomplete="false" name="confirmPassword" id="confirmPassword"/></label>
"authentication.password.confirm") %></span><input type="password" autocomplete="off" name="confirmPassword" id="confirmPassword"/></label>
</p>

<div class="submit">
Expand Down
4 changes: 2 additions & 2 deletions core-war/src/main/webapp/jobDomainPeas/jsp/userCreate.jsp
Expand Up @@ -363,14 +363,14 @@ out.println(window.printBefore());
<div class="field" id="form-row-password">
<label class="txtlibform"><fmt:message key="GML.password"/></label>
<div class="champs">
<input type="password" autocomplete="false" name="userPassword" id="userPasswordId" size="50" maxlength="32" value=""/>
<input type="password" autocomplete="off" name="userPassword" id="userPasswordId" size="50" maxlength="32" value=""/>
</div>
</div>
<!--Password again-->
<div class="field" id="form-row-passwordAgain">
<label class="txtlibform"><fmt:message key="GML.passwordAgain"/></label>
<div class="champs">
<input type="password" autocomplete="false" name="userPasswordAgain" id="userPasswordAgainId" size="50" maxlength="32" value=""/>
<input type="password" autocomplete="off" name="userPasswordAgain" id="userPasswordAgainId" size="50" maxlength="32" value=""/>
</div>
</div>
<!--Send Email-->
Expand Down
2 changes: 1 addition & 1 deletion core-war/src/main/webapp/media/jsp/pdf/viewer.jsp
Expand Up @@ -311,7 +311,7 @@
file:</p>
</div>
<div class="row">
<input type="password" autocomplete="false" id="password" class="toolbarField">
<input type="password" autocomplete="off" id="password" class="toolbarField">
</div>
<div class="buttonRow">
<button id="passwordCancel" class="overlayButton"><span data-l10n-id="password_cancel">Cancel</span>
Expand Down
Expand Up @@ -125,15 +125,15 @@
<%if (updateIsAllowed && isPasswordChangeAllowed) {%>
<tr id="oldPassword">
<td class="txtlibform"><%=resource.getString("myProfile.OldPassword")%> :</td>
<td><input <%=fieldAttribute%> type="password" autocomplete="false" name="OldPassword" size="50" maxlength="32"/></td>
<td><input <%=fieldAttribute%> type="password" autocomplete="off" name="OldPassword" size="50" maxlength="32"/></td>
</tr>
<tr>
<td class="txtlibform"><%=resource.getString("myProfile.NewPassword")%> :</td>
<td><input <%=fieldAttribute%> type="password" autocomplete="false" id="newPassword" name="NewPassword" size="50" maxlength="32"/>&nbsp;(<a tabindex="-1" href="#" onclick="$('#newPassword').focus()"><%=authRs.getString("authentication.password.showRules") %></a>)</td>
<td><input <%=fieldAttribute%> type="password" autocomplete="off" id="newPassword" name="NewPassword" size="50" maxlength="32"/>&nbsp;(<a tabindex="-1" href="#" onclick="$('#newPassword').focus()"><%=authRs.getString("authentication.password.showRules") %></a>)</td>
</tr>
<tr>
<td class="txtlibform"><%=resource.getString("myProfile.NewPasswordConfirm")%> :</td>
<td><input <%=fieldAttribute%> autocomplete="false" id="newPasswordConfirmation" name="NewPasswordConfirm" type="password" size="50" maxlength="32"/></td>
<td><input <%=fieldAttribute%> autocomplete="off" id="newPasswordConfirmation" name="NewPasswordConfirm" type="password" size="50" maxlength="32"/></td>
</tr>
<%} else { %>
<tr>
Expand Down
Expand Up @@ -164,7 +164,7 @@ else {
<div class="field">
<label class="txtlibform"><%=resource.getString("webConnections.password") %></label>
<div class="champs">
<input type="password" autocomplete="false" name="Password" maxlength="100" value="<%=password%>"/>
<input type="password" autocomplete="off" name="Password" maxlength="100" value="<%=password%>"/>
<input type="hidden" name="ConnectionId" value="<%=connection.getConnectionId()%>"/>
<input type="hidden" name="ComponentId" value="<%=connection.getComponentId()%>"/>
</div>
Expand Down

0 comments on commit 7efd360

Please sign in to comment.