Bug #11039: making the display of PDF attached files (via a permalinkURL) possible without breaking out the Silverpeas's navigation. #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilverYoCha
force-pushed
the
bug-11039
branch
from
3ec50ba
to
50f2cc9
Compare
… URL) possible without breaking out the Silverpeas's navigation. The Silverpeas's PDF viewer is now provided instead of the one of the WEB browser. As it is encapsulated into a safe iframe, there is no more side effect with the iframe of the Silverpeas's layout.
SilverYoCha
force-pushed
the
bug-11039
branch
from
50f2cc9
to
4da5512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Silverpeas's PDF viewer is now provided instead of the one of the WEB browser.
As it is encapsulated into a safe iframe, there is no more side effect with the iframe of the Silverpeas's layout.