Bug 11426 #1070
Closed
Bug 11426 #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the SocialNetwork code to lower its complexity and to remove the use of the old and deprecated Silverpeas Date objects.
Resolve the issue by taking into account only the user domains in Silverpeas that have a mapping to an XMPP domain defined in the chat.properties settings file. The rendering of silverchat and the connection opening with the remote XMPP server is only performed now if the chat service is enabled for the current user (that is if the both the chat service is enabled and the domain the user belongs to has a mapping to an XMPP domain). A default XMPP domain mapping can be now explictly set with the new property in the chat.properties settings: chat.xmpp.domain.default. If this property is set, any non explicitly mapped user domains in Silverpeas will be mapped to this default XMPP domain. If not set, then the users in the non-mapped domains in Silverpeas won't have the chat enabled for them. Add unit tests on the user account registration in the chat server.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't forget to merge after PR Silverpeas/Silverpeas-Components#693