Bug #12805 #1199
Closed
Bug #12805 #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilverYoCha
reviewed
Feb 11, 2022
| * @version %I%, %G% | ||
| */ | ||
| public abstract class AbstractNotification { | ||
| public interface UserNotification { |
There was a problem hiding this comment.
UserNotification is an interface which is already existing (in the parent package according to my memory).
Is it possible to modify the renaming from AbstractNotification to UserNotification by AbstractNotification to NotificationUrlProvider (or something in the mind)?
Add a new predefined template field valued with the URL of the server on which Silverpeas is running: notification_base_serverurl
SilverYoCha
approved these changes
Feb 14, 2022
|
Merged after rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new predefined template field valued with the URL of the server on
which Silverpeas is running: notification_base_serverurl