Feature #13791 #1297
Open
Feature #13791 #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoqui
force-pushed
the
feature-13791
branch
2 times, most recently
from
1bc4bae
to
66418ac
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mmoqui
force-pushed
the
feature-13791
branch
3 times, most recently
from
5b2a1ce
to
7ebef4c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mmoqui
force-pushed
the
feature-13791
branch
2 times, most recently
from
2697d48
to
1602c32
Compare
Fix a bug with the Silverpeas server URL for each user domain. It is now correctly set by default from the httpServerBase URL. Silverpeas uses now StringTemplate 4. With this new version of StringTemplate, a new way to define a template is now supported: the template descriptor. A template descriptor is a template definition in a file that satisfies the following schema: <template name>(<template arguments>) ::= <template body> with template arguments being a comma-list of attributes passed to the template. All the attributes set to a StringTemplate instance have to be declared here, even thoses not used in the template body. The advantage of the template descriptor is that it allows to write idented templating code. For more information about the schema, please see the StringTemplate 4 documentation or the Javadoc of SilverpeasStringTemplate. The previous syntax of StringTemplate is supported as default syntax. The existing template files are taken as a raw template in a file by StringTemplate 4. There no change otherwise the following one: idented templating code isn't supported as such; each space, each tabulation, each line-feed, etc. are taken as such when rendering the text from the raw template. This require to adapt existing templates in customer dedicated projects.
A light improvment in the message building within the Notification API. From now on, the modification of the message by the Notification API for HTML rendering is removed as it's not the goal of this API to decide how the text has to be rendered at the place of the templating; the layout and the way the message is rendered is the goal of the templates used to build any messages to send. In the unit tests on the user notification API, replace the use of the FieldMocker by NotificationSettingsMocker to mock the SettingsBundle class instances of the NotificationManagerSettings static class.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done Work
Fix a bug with the Silverpeas server URL for each user domain. It is now correctly set by default from the httpServerBase URL.
Silverpeas uses now StringTemplate 4. With this new version of StringTemplate, a new way to define a template is now supported: the template descriptor. A template descriptor is a template definition in a file that satisfies the following schema:
with
<template_arguments>being a comma-list of attributes passed to the template. All the attributes set to aStringTemplateinstance have to be declared here, even those not used in the template body. The advantage of the template descriptor is that it allows to write indented template code by surrounding the code with the following special tokens<%and%>.For more information about the schema, please see the StringTemplate 4 documentation or the Javadoc of
SilverpeasStringTemplate. The previous syntax of StringTemplate is supported as default syntax. The existing template files are taken as a raw template in a file by StringTemplate 4. There is no change otherwise the following one: indented template code isn't supported as such; each space, each tabulation, each line-feed, etc. are taken as such when rendering the text from the raw template. This require to adapt existing templates in customer dedicated projects.Related PRs
The following PRs require to be treated before this one:
The following PRs require to be treated after this one: