Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 13448 #1306

Merged
merged 2 commits into from Nov 30, 2023
Merged

Feature 13448 #1306

merged 2 commits into from Nov 30, 2023

Conversation

mmoqui
Copy link
Member

@mmoqui mmoqui commented Nov 20, 2023

  • The content of the comments isn't anymore used to set the index field TITLE and, through it, the index field HEADER dedicated to the search.
  • A new facet is introduced to select only the comments among the search results.

Merge also the PR Silverpeas/Silverpeas-Components#843

@mmoqui
Copy link
Member Author

mmoqui commented Nov 21, 2023

Rebased and merged by hand

@mmoqui mmoqui closed this Nov 21, 2023
@mmoqui mmoqui reopened this Nov 21, 2023
@mmoqui
Copy link
Member Author

mmoqui commented Nov 21, 2023

Wrong PR closed!

…o action to treat the reason of such a log. Replace the log level accordingly
Two kinds of dev:
- The comment message is removed from the index fields TITLE and HEADER.
  It is only in the index fields CONTENT and PREVIEW.
- In order to support additional facets for transverse contents (here
  for the comments), refactor the way the index field KEY is encoded:
  instead of passing the identifier of such a contribution along its
  type, define it as such in the index field KEY and add a specific
  part for the identifier of the linked object (the publication for the
  attachments or for the comments for example)
Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.19) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@SilverYoCha SilverYoCha merged commit 5ce21ed into Silverpeas:master Nov 30, 2023
3 checks passed
@mmoqui mmoqui deleted the feature-13448 branch January 25, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants