New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 13448 #1306
Merged
Merged
Feature 13448 #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebased and merged by hand |
Wrong PR closed! |
SilverYoCha
requested changes
Nov 22, 2023
core-library/src/main/java/org/silverpeas/core/index/indexing/model/IndexEntryKey.java
Show resolved
Hide resolved
core-library/src/main/java/org/silverpeas/core/index/indexing/model/IndexEntryKey.java
Show resolved
Hide resolved
...ervices/comment/src/main/java/org/silverpeas/core/comment/service/DefaultCommentService.java
Show resolved
Hide resolved
core-war/src/main/java/org/silverpeas/web/pdc/control/PdcSearchSessionController.java
Show resolved
Hide resolved
core-war/src/main/java/org/silverpeas/web/pdc/control/PdcSearchSessionController.java
Show resolved
Hide resolved
mmoqui
force-pushed
the
feature-13448
branch
from
November 23, 2023 10:11
9e8a8f4
to
608f6bb
Compare
…o action to treat the reason of such a log. Replace the log level accordingly
Two kinds of dev: - The comment message is removed from the index fields TITLE and HEADER. It is only in the index fields CONTENT and PREVIEW. - In order to support additional facets for transverse contents (here for the comments), refactor the way the index field KEY is encoded: instead of passing the identifier of such a contribution along its type, define it as such in the index field KEY and add a specific part for the identifier of the linked object (the publication for the attachments or for the comments for example)
mmoqui
force-pushed
the
feature-13448
branch
from
November 24, 2023 15:41
608f6bb
to
5ce21ed
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs 0.0% Coverage The version of Java (11.0.19) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
and, through it, the index fieldHEADER
dedicated to the search.Merge also the PR Silverpeas/Silverpeas-Components#843