Looks per domain #783
Merged
Looks per domain #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasEYSSERIC
force-pushed
the
ney-feature-3114
branch
2 times, most recently
from
af0063a
to
eb9e346
Compare
mmoqui
reviewed
Jan 30, 2017
| String selectedLook = lookSettings.getString(lookName); | ||
| SettingBundle look = ResourceLocator.getSettingBundle(selectedLook); | ||
| return look.exists(); | ||
| } catch (MissingResourceException e) { |
There was a problem hiding this comment.
When an exception is caught, it is expected one of the two behaviors:
- log the exception (in this case:
SilverLogger.error("Look named '"+lookName+" not found", e), see the exception e logged at the end of the error method) - rethrow the exception or throw another exception
When this rules don't need to be applied, then we add an exception to this rule for the incriminated code in our SonarQube.
For your case, in order to determine the better way to handle that, when the method isLookExist is called with a look name as argument, should the name exist in the look settings?
NicolasEYSSERIC
force-pushed
the
ney-feature-3114
branch
from
eb9e346
to
32b02c4
Compare
NicolasEYSSERIC
force-pushed
the
ney-feature-3114
branch
from
32b02c4
to
6ef32bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://tracker.silverpeas.org/issues/3114 for further information