Only print individual error-message if they exist #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
changed the title
rossPatton
pushed a commit
that referenced
this pull request
Jul 20, 2015
Only print individual error-message if they exist
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently writing a reporter, but I want to print out per error, not sorted into errors and warnings. Returning blank before the end creates lots of extra whitespace.
This change only prints out per violation-warnings if they exist.
Difference in my reporter is
vs.
Regarding tests: Do you have any tests on output to the console? I didn't see any, that's why I haven't written one for this change.
(Link to reporter: https://github.com/SimenB/stylint-stylish)