Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card Type Logos inconsistent styling. Can we specify a custom logo? #57

Closed
NirvanKS opened this issue Aug 6, 2021 · 0 comments · Fixed by #63
Closed

Card Type Logos inconsistent styling. Can we specify a custom logo? #57

NirvanKS opened this issue Aug 6, 2021 · 0 comments · Fixed by #63

Comments

@NirvanKS
Copy link

NirvanKS commented Aug 6, 2021

I get feedback from clients that the Visa Logo looks 'incorrect' and not what they expect, or up to standard. It does look slightly worse than others due to the white background.

Without having the burden to keep every logo up to date yourselves, can you allow developers to specify an asset image they would like to put in replacement?

An alternative would be to change the visa logo.
meetjanani pushed a commit to meetjanani/flutter_credit_card that referenced this issue Sep 28, 2021
@meetjanani-simformsolutions
SimformSolutionsPvtLtd#57 Can we specify a custom card type logos
7d8ed83
@meetjanani meetjanani mentioned this issue Sep 28, 2021
Merged
meetjanani pushed a commit to meetjanani/flutter_credit_card that referenced this issue Oct 4, 2021
@meetjanani-simformsolutions @meetjanani
🐛 SimformSolutionsPvtLtd#57 Can specify a custom card type icons
791d645
meetjanani pushed a commit to meetjanani/flutter_credit_card that referenced this issue Oct 8, 2021
@meetjanani-simformsolutions @meetjanani
🐛 SimformSolutionsPvtLtd#57 Can specify a custom card type icons
0f69a92
meetjanani pushed a commit to meetjanani/flutter_credit_card that referenced this issue Oct 11, 2021
@meetjanani-simformsolutions @meetjanani
🐛 SimformSolutionsPvtLtd#57 Can specify a custom card type icons
be494e3
vatsaltanna pushed a commit that referenced this issue Oct 11, 2021
@meetjanani-simformsolutions @vatsaltanna
🐛 #57 Can specify a custom card type icons
f1294d5
meetjanani pushed a commit to meetjanani/flutter_credit_card that referenced this issue Oct 11, 2021
@meetjanani-simformsolutions @meetjanani
🐛 SimformSolutionsPvtLtd#57 Can specify a custom card type icons
59b464f
vatsaltanna pushed a commit that referenced this issue Oct 11, 2021
@meetjanani-simformsolutions @vatsaltanna
🐛 #57 Can specify a custom card type icons
6f23f17
meetjanani pushed a commit to meetjanani/flutter_credit_card that referenced this issue Oct 11, 2021
@meetjanani-simformsolutions @meetjanani
🐛 SimformSolutionsPvtLtd#57 Can specify a custom card type icons
066a634
meetjanani pushed a commit to meetjanani/flutter_credit_card that referenced this issue Oct 11, 2021
@meetjanani-simformsolutions @meetjanani
🐛 SimformSolutionsPvtLtd#57 Can specify a custom card type icons
8e47633
meetjanani pushed a commit to meetjanani/flutter_credit_card that referenced this issue Oct 11, 2021
@meetjanani-simformsolutions @meetjanani
🐛 SimformSolutionsPvtLtd#57 Can specify a custom card type icons
90263f8
vatsaltanna-simformsolutions added a commit that referenced this issue Oct 11, 2021
@vatsaltanna-simformsolutions
Revert ":bug: #57 Can specify a custom card type icons"
7df613c 
This reverts commit 6f23f17.
meetjanani pushed a commit to meetjanani/flutter_credit_card that referenced this issue Oct 11, 2021
@meetjanani-simformsolutions @meetjanani
🐛 SimformSolutionsPvtLtd#57 Can specify a custom card type icons
c7fb4c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#57 We can specify a custom card type logos meetjanani/flutter_credit_card
1 participant
@NirvanKS