#57 We can specify a custom card type logos #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meetjanani
changed the title
example/lib/main.dart
Outdated
| @@ -77,6 +77,17 @@ class MySampleState extends State<MySample> { | |||
| useBackgroundImage ? 'assets/card_bg.png' : null, | |||
| isSwipeGestureEnabled: true, | |||
| onCreditCardWidgetChange: (CreditCardBrand creditCardBrand) {}, | |||
| cardType: CardType.mastercard, | |||
There was a problem hiding this comment.
what is the requirement of cardtype?
There was a problem hiding this comment.
Its optional parameter not required, I Removed
CHANGELOG.md
Outdated
| @@ -1,3 +1,6 @@ | |||
| ## 3.0.1 - Sep 28, 2021 | |||
There was a problem hiding this comment.
please mention this as unreleased : [Unreleased]
There was a problem hiding this comment.
Added [Unreleased] tag
vatsaltanna
reviewed
Oct 11, 2021
lib/credit_card_widget.dart
Outdated
| } | ||
|
|
||
| return icon; | ||
| } | ||
|
|
||
| List<CustomCardTypeImage> getCustomCardTypeIcon(CardType currentCardType) { | ||
| final List<CustomCardTypeImage> customCardTypeIcon = widget.customCardIcons |
There was a problem hiding this comment.
No requirement to use variable, you can directly return the value
vatsaltanna
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❇️ fix #57 We Can specify a custom card type logos