Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 PR title validation workflow issue #322

Conversation

ShwetaChauhan18
Copy link
Contributor

Description

  • fix: 🐛 PR title validation workflow issue

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@vatsaltanna vatsaltanna marked this pull request as draft January 4, 2023 06:36
@ujas-m-simformsolutions ujas-m-simformsolutions marked this pull request as ready for review January 4, 2023 06:39
@ShwetaChauhan18 ShwetaChauhan18 force-pushed the fix/title_validation_workflow_issue branch 4 times, most recently from 17d2ddd to 7dbfb04 Compare January 4, 2023 06:50
@ShwetaChauhan18 ShwetaChauhan18 changed the title fix: 🐛 PR title validation workflow issue fix: PR title validation workflow issue Jan 4, 2023
@ShwetaChauhan18 ShwetaChauhan18 force-pushed the fix/title_validation_workflow_issue branch 3 times, most recently from 73ca7c2 to 7227acf Compare January 4, 2023 06:55
@ShwetaChauhan18 ShwetaChauhan18 changed the title fix: PR title validation workflow issue fix:🐛 PR title validation workflow issue Jan 4, 2023
@ShwetaChauhan18 ShwetaChauhan18 changed the title fix:🐛 PR title validation workflow issue fix: 🐛 PR title validation workflow issue Jan 4, 2023
@ShwetaChauhan18 ShwetaChauhan18 force-pushed the fix/title_validation_workflow_issue branch from 7227acf to 28b6c9c Compare January 4, 2023 07:01
@vatsaltanna vatsaltanna merged commit d4f1144 into SimformSolutionsPvtLtd:master Jan 4, 2023
satria-wardana added a commit to satria-wardana/flutter_showcaseview that referenced this pull request Sep 7, 2023
* master: (55 commits)
  📝 Update CHANGELOG.md file for version 2.0.3. (SimformSolutionsPvtLtd#368)
  feat: ✨ Add callback when barrier has been clicked (SimformSolutionsPvtLtd#359)
  fixed-child-constructor-invocation (SimformSolutionsPvtLtd#361)
  ✨ (SimformSolutionsPvtLtd#148) Add feasibility to add `textDirection` of `title` and `description`. (SimformSolutionsPvtLtd#356)
  fix: 🐛 SimformSolutionsPvtLtd#346 Don't respond to any clicks in target & (SimformSolutionsPvtLtd#351)
  fix: 🐛 Flutter inspector makes screen grey (SimformSolutionsPvtLtd#353)
  🔖 version bump 2.0.0+1 to 2.0.1 (SimformSolutionsPvtLtd#341)
  fix: 🐛 Take in account view insets (such as keyboard) (SimformSolutionsPvtLtd#288)
  Miscellaneous changes
  Add missing copyright notice in enum.dart
  feat: ✨ Add padding to title and description
  fix: 🐛 PR title validation workflow issue (SimformSolutionsPvtLtd#322)
  feat: ✨ Provide Manual option for vertical position of tooltip (SimformSolutionsPvtLtd#306)
  feat: ✨ Enable/disable showcase globally. (SimformSolutionsPvtLtd#319)
  ✨ add mac support in example. (SimformSolutionsPvtLtd#197)
  Fix: 🔨 Remove title validation workflow (SimformSolutionsPvtLtd#321)
  chore: 👷workflow for PR title validation (SimformSolutionsPvtLtd#286)
  release: 🔖 version bump 2.0.0 to 2.0.0+1 (SimformSolutionsPvtLtd#302)
  release: 🔖 version bump 1.1.8 to 2.0.0 (SimformSolutionsPvtLtd#301)
  fix: 🐛 logic update in `tooltip_widget.dart` (SimformSolutionsPvtLtd#300)
  ...

# Conflicts:
#	example/ios/Flutter/AppFrameworkInfo.plist
#	example/ios/Runner.xcodeproj/project.pbxproj
#	example/lib/main.dart
#	lib/src/showcase.dart
#	lib/src/showcase_widget.dart
#	lib/src/tooltip_widget.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants