Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: child-constructor-invocation #361

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

yeasin50
Copy link
Contributor

Description

fixed child-constructor-invocation issue caused on

sdk: '>=2.19.3 <3.0.0' with flutter_lints: ^2.0.0.

As for the example code, it also marches the format.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@ujas-m-simformsolutions ujas-m-simformsolutions changed the title fix:child-constructor-invocation fix: child-constructor-invocation Mar 20, 2023
Copy link
Contributor

@ujas-m-simformsolutions ujas-m-simformsolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vatsaltanna vatsaltanna merged commit 1f43302 into SimformSolutionsPvtLtd:master Mar 22, 2023
satria-wardana added a commit to satria-wardana/flutter_showcaseview that referenced this pull request Sep 7, 2023
* master: (55 commits)
  📝 Update CHANGELOG.md file for version 2.0.3. (SimformSolutionsPvtLtd#368)
  feat: ✨ Add callback when barrier has been clicked (SimformSolutionsPvtLtd#359)
  fixed-child-constructor-invocation (SimformSolutionsPvtLtd#361)
  ✨ (SimformSolutionsPvtLtd#148) Add feasibility to add `textDirection` of `title` and `description`. (SimformSolutionsPvtLtd#356)
  fix: 🐛 SimformSolutionsPvtLtd#346 Don't respond to any clicks in target & (SimformSolutionsPvtLtd#351)
  fix: 🐛 Flutter inspector makes screen grey (SimformSolutionsPvtLtd#353)
  🔖 version bump 2.0.0+1 to 2.0.1 (SimformSolutionsPvtLtd#341)
  fix: 🐛 Take in account view insets (such as keyboard) (SimformSolutionsPvtLtd#288)
  Miscellaneous changes
  Add missing copyright notice in enum.dart
  feat: ✨ Add padding to title and description
  fix: 🐛 PR title validation workflow issue (SimformSolutionsPvtLtd#322)
  feat: ✨ Provide Manual option for vertical position of tooltip (SimformSolutionsPvtLtd#306)
  feat: ✨ Enable/disable showcase globally. (SimformSolutionsPvtLtd#319)
  ✨ add mac support in example. (SimformSolutionsPvtLtd#197)
  Fix: 🔨 Remove title validation workflow (SimformSolutionsPvtLtd#321)
  chore: 👷workflow for PR title validation (SimformSolutionsPvtLtd#286)
  release: 🔖 version bump 2.0.0 to 2.0.0+1 (SimformSolutionsPvtLtd#302)
  release: 🔖 version bump 1.1.8 to 2.0.0 (SimformSolutionsPvtLtd#301)
  fix: 🐛 logic update in `tooltip_widget.dart` (SimformSolutionsPvtLtd#300)
  ...

# Conflicts:
#	example/ios/Flutter/AppFrameworkInfo.plist
#	example/ios/Runner.xcodeproj/project.pbxproj
#	example/lib/main.dart
#	lib/src/showcase.dart
#	lib/src/showcase_widget.dart
#	lib/src/tooltip_widget.dart
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_showcaseview that referenced this pull request Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The child should be last widget on constructor invocations.
3 participants