Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update target python versions #58

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

23pointsNorth
Copy link
Contributor

As per https://devguide.python.org/versions/ Python version 3.5 and 3.6 are EOL. It would make sense to continue testing on 3.6 -> 3.11

@SimonBlanke
Copy link
Owner

Hello @23pointsNorth,

good idea! I ran all tests for 3.10 and 3.11 yesterday and I found the following problems:

  • 3.10 is interpreted as 3.1 in the test matrix. You can read more about it in this article. The solution is to put double quotes around each version number to change the type to string.
  • 3.11 has breaking changes for the random-module. You can read more about it in this issue. I got the same error when testing the optimization-backend in 3.11. So we have to do without 3.11 support for the time being. If you like you can open an issue for v3.11 support (you can skip the issue template for that one).
  • I would like to keep testing in version 3.5 for now (unless there is a strong argument against it). 3.5 has unordered dictionaries, which might return in future versions of python. Making Hyperactive work with unordered dictionaries was pretty difficult. So I would like to keep this on my radar for now.

I didn't expect this to blow up like this, but I am grateful, because I learned a lot reading about these problems :-)

Let me know what you think about these problems.

Copy link
Owner

@SimonBlanke SimonBlanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes from: #58 (comment)

@23pointsNorth
Copy link
Contributor Author

23pointsNorth commented Nov 10, 2022

Hi @SimonBlanke ,
Thanks for the good links above. With the GFO fix, I've updated the testing matrix to include a string version representation like the GFO repo.

As far as I know, as an open source project it makes no difference per se (i.e. not sure when would make sense to sunset versions)?
Let's see what the CI says and feel free to edit/change things as required.

Are there any timing tests? Would be nice to see if there is any speed difference between the versions :)

@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Base: 90.97% // Head: 90.97% // No change to project coverage 👍

Coverage data is based on head (c75d536) compared to base (6c11700).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   90.97%   90.97%           
=======================================
  Files          15       15           
  Lines         654      654           
=======================================
  Hits          595      595           
  Misses         59       59           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SimonBlanke SimonBlanke merged commit 0c15769 into SimonBlanke:master Nov 16, 2022
@SimonBlanke
Copy link
Owner

Hello @23pointsNorth,

thanks for the contribution! :-)
I was a bit reluctant to merge, because of the error: Version 3.5 with arch x64 not found. But it did not occur on my end.
Maybe 3.5 is interpreted as 3.5.0 (which is not supported), but that is just speculation. If it occurs again I will try to write the version as "3.5.x".

Are there any timing tests?

Currently not, but I do not expect any significant speed-ups on our end. Usually the biggest part of the computation time is spend on the model inside the objective-function (the smbo might be an exception). But it would be interesting to see how it affects Hyperactive.

@23pointsNorth
Copy link
Contributor Author

Looking at the CI everything looks green, so hopefully, it wasn't too much of a hassle.

Thanks for the great library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants