-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Dockerfile #274
add Dockerfile #274
Conversation
@SimonKagstrom I'll add you to the org as an admin (docker hub id?) and then you can point the kcov automated build over at this repo and it'll set up the github hooks. |
You can see/use the current builds here https://hub.docker.com/r/mmlb/kcov/ |
But that would be based on the current debian:stable. It may make more sense to just retag those v31-v33 so nothing changes for any users. |
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
=======================================
Coverage 70.15% 70.15%
=======================================
Files 57 57
Lines 3689 3689
=======================================
Hits 2588 2588
Misses 1101 1101 Continue to review full report at Codecov.
|
Ther formatted output does not change.
@mmlb I'm SimonK on docker hub, although I've hardly used it so far. Thanks for the changes! |
@SimonKagstrom I've added you to the owner's team on dockerhub. I can't create the automated build because I don't have write access to here on github. Can you create the automated build and I can tweak afterwards? Its not super obvious but you need to click "Create" dropdown next to your username, like so |
Hmm... I hope I managed to create it. I think I might have managed to create one on my own user as well by mistake. It now gets stuck when I press create, but let's see how it turns out. |
I don't see anything yet, iirc it took a few minutes for hub to create the repo correctly. Also you may need to refresh perms or something so that docker hub picks up that you're part of the kcov org, did you see that as an option when creating the automated build? |
Ok, I realised my mistake. It's not SimonK, but simonkagstrom which is the user. Sorry about that! That explains why I wasn't in the organization I guess, although SimonK is also welcome :-) |
done, try again now? |
I think it has been created now, thanks! |
nice! I've added triggers for tags, manually triggered a build of master and will soon push the same v31-v33 images as was on the previous repo. I can also build v34-v36 using same Dockerfile and push them up. |
Just pushed up the v31-v33 images:
|
v34 and v35 were generated with tweaked Dockerfile, v36 was unchanged: --- ../Dockerfile 2018-10-24 16:52:08.898668548 -0400
+++ Dockerfile 2018-10-24 16:56:06.398770774 -0400
@@ -51,6 +51,5 @@
COPY --from=builder /lib/x86_64-linux-gnu/*.so* /lib/x86_64-linux-gnu/
COPY --from=builder /usr/lib/x86_64-linux-gnu/*.so* /usr/lib/x86_64-linux-gnu/
COPY --from=builder /usr/local/bin/kcov* /usr/local/bin/
-COPY --from=builder /usr/local/share/doc/kcov /usr/local/chare/doc/kcov
CMD ["/usr/local/bin/kcov"]
kcov / |
This image seems to not be maintained since 6 years, maybe delete or update it ? I did open a PR at shellspec/kcov-docker#1 to have this other image updated |
@williamdes the "official" docker images are at https://hub.docker.com/r/kcov/kcov, which are update on releases (and also on each commit). Anyway, thanks for keeping the shellspec/kcov-docker up-to-date! |
Thank you, I did not know |
Absolutely! I should say that this was contributed by another guy, I still use docker quite infrequently, and am by no means an expert at it. |
fixes #273