Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Dockerfile #274

Merged
merged 4 commits into from
Oct 20, 2018
Merged

add Dockerfile #274

merged 4 commits into from
Oct 20, 2018

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Oct 19, 2018

fixes #273

@mmlb
Copy link
Contributor Author

mmlb commented Oct 19, 2018

@SimonKagstrom I'll add you to the org as an admin (docker hub id?) and then you can point the kcov automated build over at this repo and it'll set up the github hooks.

@mmlb
Copy link
Contributor Author

mmlb commented Oct 19, 2018

You can see/use the current builds here https://hub.docker.com/r/mmlb/kcov/

@mmlb
Copy link
Contributor Author

mmlb commented Oct 19, 2018

Also, I just learned that I'll be able to trigger builds for older tags using curl, so we can have same tags as found on https://hub.docker.com/r/ragnaroek/kcov/tags/, namely v31-v33. (There's no Dockerfile so it won't build 🤦‍♂️ )

But that would be based on the current debian:stable. It may make more sense to just retag those v31-v33 so nothing changes for any users.

@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #274 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #274   +/-   ##
=======================================
  Coverage   70.15%   70.15%           
=======================================
  Files          57       57           
  Lines        3689     3689           
=======================================
  Hits         2588     2588           
  Misses       1101     1101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef2a31...cd20bba. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 19, 2018

Coverage Status

Coverage remained the same at 70.155% when pulling cd20bba on mmlb:automated-docker-builds into 1ef2a31 on SimonKagstrom:master.

@SimonKagstrom SimonKagstrom merged commit 3d94729 into SimonKagstrom:master Oct 20, 2018
@SimonKagstrom
Copy link
Owner

@mmlb I'm SimonK on docker hub, although I've hardly used it so far.

Thanks for the changes!

@mmlb mmlb deleted the automated-docker-builds branch October 23, 2018 14:34
@mmlb
Copy link
Contributor Author

mmlb commented Oct 23, 2018

@SimonKagstrom I've added you to the owner's team on dockerhub. I can't create the automated build because I don't have write access to here on github. Can you create the automated build and I can tweak afterwards?

Its not super obvious but you need to click "Create" dropdown next to your username, like so

@SimonKagstrom
Copy link
Owner

Hmm... I hope I managed to create it. I think I might have managed to create one on my own user as well by mistake.

It now gets stuck when I press create, but let's see how it turns out.

@mmlb
Copy link
Contributor Author

mmlb commented Oct 23, 2018

I don't see anything yet, iirc it took a few minutes for hub to create the repo correctly. Also you may need to refresh perms or something so that docker hub picks up that you're part of the kcov org, did you see that as an option when creating the automated build?

@SimonKagstrom
Copy link
Owner

Ok, I realised my mistake. It's not SimonK, but simonkagstrom which is the user. Sorry about that! That explains why I wasn't in the organization I guess, although SimonK is also welcome :-)

@mmlb
Copy link
Contributor Author

mmlb commented Oct 24, 2018

done, try again now?

@SimonKagstrom
Copy link
Owner

I think it has been created now, thanks!

@mmlb
Copy link
Contributor Author

mmlb commented Oct 24, 2018

nice! I've added triggers for tags, manually triggered a build of master and will soon push the same v31-v33 images as was on the previous repo. I can also build v34-v36 using same Dockerfile and push them up.

@mmlb
Copy link
Contributor Author

mmlb commented Oct 24, 2018

Just pushed up the v31-v33 images:

❯ docker images | grep kcov | sort -k 3
kcov/kcov                        v33                            5771c83b3b0d        21 months ago       520MB
ragnaroek/kcov                   v33                            5771c83b3b0d        21 months ago       520MB
kcov/kcov                        v31                            796274bf3329        2 years ago         530MB
ragnaroek/kcov                   v31                            796274bf3329        2 years ago         530MB
kcov/kcov                        v32                            f34f09d5663e        21 months ago       519MB
ragnaroek/kcov                   v32                            f34f09d5663e        21 months ago       519MB```

@mmlb
Copy link
Contributor Author

mmlb commented Oct 24, 2018

v34 and v35 were generated with tweaked Dockerfile, v36 was unchanged:

--- ../Dockerfile       2018-10-24 16:52:08.898668548 -0400
+++ Dockerfile  2018-10-24 16:56:06.398770774 -0400
@@ -51,6 +51,5 @@
 COPY --from=builder /lib/x86_64-linux-gnu/*.so* /lib/x86_64-linux-gnu/
 COPY --from=builder /usr/lib/x86_64-linux-gnu/*.so* /usr/lib/x86_64-linux-gnu/
 COPY --from=builder /usr/local/bin/kcov* /usr/local/bin/
-COPY --from=builder /usr/local/share/doc/kcov /usr/local/chare/doc/kcov

 CMD ["/usr/local/bin/kcov"]

kcov /

@williamdes
Copy link
Contributor

You can see/use the current builds here https://hub.docker.com/r/mmlb/kcov/

This image seems to not be maintained since 6 years, maybe delete or update it ?

I did open a PR at shellspec/kcov-docker#1 to have this other image updated

@SimonKagstrom
Copy link
Owner

@williamdes the "official" docker images are at https://hub.docker.com/r/kcov/kcov, which are update on releases (and also on each commit).

Anyway, thanks for keeping the shellspec/kcov-docker up-to-date!

@williamdes
Copy link
Contributor

@williamdes the "official" docker images are at https://hub.docker.com/r/kcov/kcov, which are update on releases (and also on each commit).

Anyway, thanks for keeping the shellspec/kcov-docker up-to-date!

Thank you, I did not know
Would you accept a multi arch setup for the Docker image?
The Dockerfile seems outdated I might try to refresh it to bookworm

@SimonKagstrom
Copy link
Owner

Absolutely!

I should say that this was contributed by another guy, I still use docker quite infrequently, and am by no means an expert at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker images are stale
4 participants