forked from juju/juju
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request juju#13056 from wallyworld/deploy-bundle-diff
juju#13056 When deploying over the top of an existing model a bundle that contains charm config values set to the charm default, juju would claim that config had changed when it hadn't. Any default charm values were being removed from the model representation to compare, instead of unset values. ## QA steps juju deploy a simple bundle with a config option set to the charm default ``` applications: mariadb: charm: cs:mariadb num_units: 1 options: dataset-size: 50% ``` `juju export-bundle --filename foo.yaml` `juju deploy ./foo.yaml --verbose --dry-run --map-machines existing` There should be no changes printed. ## Bug reference https://bugs.launchpad.net/juju/+bug/1929908
- Loading branch information
Showing
5 changed files
with
17 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
options: | ||
dataset-size: | ||
default: '80%' | ||
description: How much data do you want to keep in memory in the DB. | ||
type: string |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
options: | ||
dataset-size: | ||
default: '80%' | ||
description: How much data do you want to keep in memory in the DB. | ||
type: string |