Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Queue Stats On Queue Joining Page #424

Closed
daltonfury42 opened this issue Dec 12, 2020 · 7 comments · Fixed by #482
Closed

Show Queue Stats On Queue Joining Page #424

daltonfury42 opened this issue Dec 12, 2020 · 7 comments · Fixed by #482
Labels
good first issue Good for newcomers You Can Do This Will be accepted on priority

Comments

@daltonfury42
Copy link
Collaborator

It will be good to show the total number of people in the queue, before the user joins the queue. We could show the entire queue stats in the joining page.

@sajmalyousef
Copy link
Member

Sounds like a great idea , this would help people avoid crowded places

@maaverik
Copy link
Collaborator

https://xd.adobe.com/view/ad1db074-03bf-45b1-537b-98d9d524ec82-db2c/screen/e654742e-fb91-4a5c-83d6-4dff807e03ea/?fullscreen

It's part of the original design, we just hadn't gotten around to it. @sajmalyousef, the intent of simplq is for people to not have to go anywhere till their turn is up, whether it's crowded or not, right?

@daltonfury42
Copy link
Collaborator Author

daltonfury42 commented Dec 12, 2020 via email

@daltonfury42
Copy link
Collaborator Author

daltonfury42 commented Jan 16, 2021

Go to home page and join an already created queue, like 'aa'. Currently the gage looks like this:

image

When the page is loaded, we are already fetching the required stats for the queue from the backend:

/v1/queue/status?queueName=aa
{
   "queueId":"49b1ffa6-87fd-4a46-b95f-5588711cecca",
   "queueName":"aa",
   "status":"ACTIVE",
   "numberOfActiveTokens":0,
   "totalNumberOfTokens":0,
   "queueCreationTimestamp":"2020-12-15T08:07:55.374+0000"
}

We need to define a new component and use it in here.

image

(We can fine tune the text later)

@daltonfury42 daltonfury42 added good first issue Good for newcomers You Can Do This Will be accepted on priority labels Jan 16, 2021
@mradenovic
Copy link
Collaborator

Queue Stats data already appears in QueueDetails component. I could extract it and make a reusable component to be used in Join and Admin pages:

      <div className={styles['detail']}>
        <DetailRow
          title="People currently in queue:"
          value={queueStatusResponse?.numberOfActiveTokens}
          large
        />
        <DetailRow title="Queue creation time:" value={creationTime} />
        <DetailRow
          title="Total number of people joined in queue:"
          value={queueStatusResponse?.totalNumberOfTokens}
        />
      </div>

@daltonfury42
Copy link
Collaborator Author

daltonfury42 commented Jan 23, 2021

I see, right. I missed this. We should refactor this out, fix the alignment and reuse it.

image

I feel also that the Queue Details should be expanded by default, if you are going to work on this, you can take care of it?

@mradenovic
Copy link
Collaborator

mradenovic commented Jan 23, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers You Can Do This Will be accepted on priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants