Assert primal/dual residual and dual gap != nan + add unittest #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcarpent
force-pushed
the
topic/add-unittest
branch
from
6a1fa0e
to
30c04d1
Compare
jcarpent
reviewed
Nov 14, 2022
Co-authored-by: Justin Carpentier <justin.carpentier@inria.fr>
for more information, see https://pre-commit.ci
jcarpent
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after #114 , all unittests are passing in Release and Debug mode (which is now checking for primal/dual residual and duality gap != nan). Before the fix in #114, we had certain tests failing with the assert duality gap isnan.
problem was observed in #113. The example provided by @stephane-caron was added as python unittest in proxsuite.