New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add duality-gap thresholds #169
Add duality-gap thresholds #169
Conversation
Hi ! This project doesn't usually accept pull requests on the main branch. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stephane-caron for the PR.
I would just recommend changing the choice of variable naming to use the full name duality_gap
for clarity and transparency.
This is a proposal, see #169 If we don't do that, then we should update the documentation (formulae and parallel with the SCS API).
Addresses #169
for more information, see https://pre-commit.ci
Ready for review! The main difference since last review is the proposal to replace the instructions:
By a recommendation in the docs:
The rationale for it is that the new parameters allow users to decide by themselves how they want to handle the duality gap. |
Working draft accompanying the discussion in #168
Closes #168