Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dense LP interface #231

Merged
merged 4 commits into from Jun 19, 2023

Conversation

Bambade
Copy link
Collaborator

@Bambade Bambade commented Jun 19, 2023

Add a setting option for solving more efficiently Linear Programs with ProxQP, as suggested by #173 (i.e., all linear algebra operations involving the Hessian cost are avoided).

This PR adds this feature for ProxQP dense backend. It will be added later for ProxQP sparse backend as well.

test/src/dense_qp_eq.cpp Outdated Show resolved Hide resolved
test/src/dense_qp_eq.cpp Outdated Show resolved Hide resolved
jcarpent
jcarpent previously approved these changes Jun 19, 2023
Copy link
Member

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bambade Could you approved my suggested change?

Co-authored-by: Justin Carpentier <justin.carpentier@inria.fr>
Co-authored-by: Justin Carpentier <justin.carpentier@inria.fr>
@jcarpent jcarpent enabled auto-merge June 19, 2023 16:48
@costashatz
Copy link
Contributor

This is great guys! Thanks! Do you have any benchmark on the performance gains?

@jcarpent
Copy link
Member

Solving #47.

@jcarpent jcarpent merged commit 096c362 into Simple-Robotics:devel Jun 19, 2023
62 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants