Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SQL execution via update #2

Merged
merged 5 commits into from
Aug 10, 2020
Merged

Conversation

benwalk
Copy link

@benwalk benwalk commented Aug 4, 2020

With the need to set up base configuration (schemas, roles, privileges, tables, functions, etc.) for replication slots, the ability to execute a provided SQL statement via cf update-service greatly enhances service owner's ability to self-serve.

Copy link

@kaiju kaiju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation?

@benwalk benwalk requested a review from kaiju August 5, 2020 16:26
Copy link

@kaiju kaiju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing that comes to mind is that we may want to make execute_statement exclusive? Otherwise every bit of service update runs, including parameter group updates, etc, every time I we issue a statement via update-service

@benwalk
Copy link
Author

benwalk commented Aug 10, 2020

I had a similar thought, but what if someone wants to trigger both during a single update call? 🤔 I could go either way, but your stamp tells me you don't have a strong opinion either way either.

@benwalk benwalk merged commit 6031a51 into master Aug 10, 2020
@benwalk benwalk deleted the INFRA-854/replication-slots branch August 11, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants