Update the favicon #4394
Merged
Update the favicon #4394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gwenwyfar <gwenwyfar@protonmail.com>
|
i would post this on the team boards to get further input, i am not sure if this violates our trademarks by doing this change to the image. as far as i know it has always been black inside the fulcrum and not the other way around, so this is a bit of a major change. |
|
A very fine upgrade |
colinschoen
approved these changes
Dec 5, 2017
|
To me, that looks like the logo on github for SMF. Check here: |
|
@sbulen it is, that one was updated a few months back, and the previous (almost identical) one was one of the main bases for it. So the current Github logo, the new 2.1 header logo and this favicon are identical. Hoping we can update the others soon as well, once trademark issues are sorted :) |
|
Per discussion in team boards this seems fine. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's using the same proportions as the new svg logo, and updated to contain all .ico favicon sizes. Total size could've been smaller but this image in particular kept resulting in a lot of aliasing in other converters.
Since it uses transparency it will work better for places outside the browser tab, and in different backgrounds. Color and style were a mix of old favicon vs new curve theme.
Samples:
