-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.0] Fix exdates not having a default value #8235
base: release-3.0
Are you sure you want to change the base?
[3.0] Fix exdates not having a default value #8235
Conversation
Spotted this with @Sesquipedalian Something must've changed in 8.0 because SMF 2.1 was already using STRICT_TRANS_TABLES |
Indeed, the MySQL 8.0.13 release notes include this feature. I added the default value to Postgres as well, but I don't know if that's needed. |
The real question is, why is the installer complaining about this for the |
Understood, I will try to dig into this this weekend |
Cool. Thanks! |
Sounds like we might be trying to insert data into that particular table without setting a value for that column. That's usually what triggers the "column doesn't have a default value" error. |
Oldiesmann is actually right: My preference for this kind of things is to actually set the default value upon table creation, but as I understand it, it won't be compatible for MySQL versions prior to 8.0.13 so, might just tweak that query to include the default value for Am I right? :) |
Either option will work actually. The current minimum MySQL version for 3.0 is 8.0.35, and it would appear that Postgres also supports default values for text columns. Since it's just one query though it might be easier to just fix that query. |
The real problem here is we are now inconsistent. IMO, we should be adding defaults on ALL the text values. This requires updates throughout the installer & upgrader. |
We didn't done this, |
I was getting an error upon installing that this field didn't have a default value.