-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] "Follow System Theme" #135
Comments
you mean toggling dark/light themes, or something more advanced? |
I mean something more advanced. And again, I am not sure if this is possible... Looking a bit deeper though, this may be specific to Lineage OS, but I believe it also applies to Oxygen OS (OnePlus Phones). |
dont you mean this? #58 |
Yes and no... I would try to avoid using APIs that are specific to just one ROM, but seeing that they moved to the Android 10 built in theme picker maybe this is more possible than I thought :) |
What @Prog1563 means is https://material.io/develop/android/theming/dark, which is a built-in feature of material design (and we are already using the material library). Are you interested in switching the base theme from |
I will have to play around with it, not sure how it works or looks now |
If you need any help or don't know how to do it correctly, I can do with the simple transition as I've done it for F-droid and FairEmail. |
ok so this issue doesn't sem to be specifically about the dark / night mode setting, as mentioned here #135 (comment) although honestly, just having two themes to switch between, or just switching the background colour, etc., is all i'm really looking for . it would be nice if it got colours from the system UI, but i think the dark / night theme is more important . should i make a seperate issue for that specifically ? or does that just fall under the scope of this one ? |
those are still two seperate things though |
Oh wait, I got you. Sorry, misread your post, my bad... In regard to both though, I think Android 12 might put a lot of this up in the air. Looks like they are doing a massive UI overhaul that might change a LOT of these conversations. |
One of the only things that keeps me from removing all system apps from my ROM and using all simple mobile tools instead of only using some of the apps to replace apps that the ROM didn't come with is the design of the apps. If at least the app colors synced up with the ones applied in the Settings app, or even better, just used the newer Material interfaces, not the one very similar with Android 5, I would instantly switch to all of the apps. For me, the app's design, coherence with the rest of the system, and colors are all deciding factors when choosing apps and I'd love to use only these apps, if they had a better look. |
a new Auto theme has just been added into Simple Commons, it will eventually reach all apps starting with App Launcher and Calculator. It will toggle text, background and navigation bar colors, we cannot really access or use the system accent color. |
On Android 12, Material You is available and the system palette is accessible through the |
How come unlike the other theme options, this can't be applied to all apps in one click? |
Apps using the auto theme option also don't switch themes immediately after the theme has been switched, but only after closing and reopening the app.. |
|
Why is that?
No, that works fine. What I mean is if I set the theme to auto and then change the system theme, it doesn't change the app's theme to the new system theme until I close and reopen it |
I have been using your apps for a while now on LineageOS and absolutely love the work that y'all have done!
There is one thing that has been bugging me a little lately though with the advent of LOS 17.1... The new theme engine...
It would be absolutely spectacular if we had an option to "Follow system theme" instead of setting the colors ourselves.
Maybe there is a way to use the system's background, text and accent colors?
I'm not sure what the compatibility looks like for other AOSP/Android distributions or if this is even possible, but either way I would love to hear back 👍
Keep up the great work everyone! ❤️
The text was updated successfully, but these errors were encountered: