Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] "Follow System Theme" #135

Closed
Subnet-Masked opened this issue Sep 14, 2020 · 18 comments
Closed

[Feature Request] "Follow System Theme" #135

Subnet-Masked opened this issue Sep 14, 2020 · 18 comments

Comments

@Subnet-Masked
Copy link

I have been using your apps for a while now on LineageOS and absolutely love the work that y'all have done!
There is one thing that has been bugging me a little lately though with the advent of LOS 17.1... The new theme engine...
It would be absolutely spectacular if we had an option to "Follow system theme" instead of setting the colors ourselves.

Maybe there is a way to use the system's background, text and accent colors?

I'm not sure what the compatibility looks like for other AOSP/Android distributions or if this is even possible, but either way I would love to hear back 👍

Keep up the great work everyone! ❤️

@tibbi
Copy link
Contributor

tibbi commented Sep 14, 2020

you mean toggling dark/light themes, or something more advanced?

@Subnet-Masked
Copy link
Author

I mean something more advanced. And again, I am not sure if this is possible...
What I mean is actually using the accent color and the light/dark mode of the device that you set in Android's settings (Settings > Display > Advanced > Styles & Wallpapers > Edit > Color)

Looking a bit deeper though, this may be specific to Lineage OS, but I believe it also applies to Oxygen OS (OnePlus Phones).
I don't know how compatible the API is though or if it is different between ROMs
https://wiki.lineageos.org/sdk/api/styles.html

@tibbi
Copy link
Contributor

tibbi commented Sep 14, 2020

dont you mean this? #58

@Subnet-Masked
Copy link
Author

Yes and no... I would try to avoid using APIs that are specific to just one ROM, but seeing that they moved to the Android 10 built in theme picker maybe this is more possible than I thought :)

@proletarius101
Copy link

proletarius101 commented Jan 24, 2021

What @Prog1563 means is https://material.io/develop/android/theming/dark, which is a built-in feature of material design (and we are already using the material library). Are you interested in switching the base theme from Theme.AppCompat to Theme.MaterialComponents.DayNight (with automatic action bar) or Theme.MaterialComponents.DayNight.NoActionBar? If you don't have time to do this or have no idea how it works, I will be happy to make a PR, as long as you agree that we should use the new, modern looking

@tibbi
Copy link
Contributor

tibbi commented Jan 24, 2021

I will have to play around with it, not sure how it works or looks now

@proletarius101
Copy link

I will have to play around with it, not sure how it works or looks now

If you need any help or don't know how to do it correctly, I can do with the simple transition as I've done it for F-droid and FairEmail.

@theotheroracle
Copy link

ok so this issue doesn't sem to be specifically about the dark / night mode setting, as mentioned here #135 (comment) although honestly, just having two themes to switch between, or just switching the background colour, etc., is all i'm really looking for . it would be nice if it got colours from the system UI, but i think the dark / night theme is more important . should i make a seperate issue for that specifically ? or does that just fall under the scope of this one ?

@Subnet-Masked
Copy link
Author

The following screenshots from my OP8T is what I am talking about with the "Follow system theme" since you can change from light/dark (day/night) mode and change the system accent colors.

Screenshot_20210608-102635
Screenshot_20210608-102646
Screenshot_20210608-102628

@theotheroracle
Copy link

those are still two seperate things though

@Subnet-Masked
Copy link
Author

Oh wait, I got you. Sorry, misread your post, my bad...

In regard to both though, I think Android 12 might put a lot of this up in the air. Looks like they are doing a massive UI overhaul that might change a LOT of these conversations.

@Andy3153
Copy link

One of the only things that keeps me from removing all system apps from my ROM and using all simple mobile tools instead of only using some of the apps to replace apps that the ROM didn't come with is the design of the apps. If at least the app colors synced up with the ones applied in the Settings app, or even better, just used the newer Material interfaces, not the one very similar with Android 5, I would instantly switch to all of the apps. For me, the app's design, coherence with the rest of the system, and colors are all deciding factors when choosing apps and I'd love to use only these apps, if they had a better look.

@tibbi
Copy link
Contributor

tibbi commented Nov 3, 2021

a new Auto theme has just been added into Simple Commons, it will eventually reach all apps starting with App Launcher and Calculator. It will toggle text, background and navigation bar colors, we cannot really access or use the system accent color.

@tibbi tibbi closed this as completed Nov 3, 2021
@zhaofengli
Copy link

On Android 12, Material You is available and the system palette is accessible through the @android:color/system_* resources. On the platform side, the wallpaper color extractor is closed-source and not available in AOSP yet, though it's expected to be added in the upcoming version and an alternative implementation is available. You can use the 12.1/Sv2 emulator images to test.

@julianfairfax
Copy link

a new Auto theme has just been added into Simple Commons, it will eventually reach all apps starting with App Launcher and Calculator. It will toggle text, background and navigation bar colors, we cannot really access or use the system accent color.

How come unlike the other theme options, this can't be applied to all apps in one click?

@julianfairfax
Copy link

Apps using the auto theme option also don't switch themes immediately after the theme has been switched, but only after closing and reopening the app..

@tibbi
Copy link
Contributor

tibbi commented Dec 28, 2021

  1. because you can set either Auto or Shared theme, not both
  2. theme should be switched right after confirming it. If not, it might be some issue with specific colors or some system specific glitch

@julianfairfax
Copy link

  1. because you can set either Auto or Shared theme, not both

Why is that?

  1. theme should be switched right after confirming it. If not, it might be some issue with specific colors or some system specific glitch

No, that works fine. What I mean is if I set the theme to auto and then change the system theme, it doesn't change the app's theme to the new system theme until I close and reopen it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants