Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid NoSourceSince #1706

Open
piu130 opened this issue Jan 5, 2020 · 11 comments
Open

F-Droid NoSourceSince #1706

piu130 opened this issue Jan 5, 2020 · 11 comments

Comments

@piu130
Copy link

@piu130 piu130 commented Jan 5, 2020

F-Droid marked your app with This app has features you may not like: NoSourceSince.
Do you know why and how to fix this? :)

Is this, because of the license change? Or because of the new photo editor?

Latest release was 6.10.8 on F-Droid.

F-Droid Link.

@darhma

This comment has been minimized.

Copy link

@darhma darhma commented Jan 6, 2020

@piu130
I think it is due to the photo editor that is not open source so either a fully open source version for f-droid is maintained or updates will no longer be available

@tibbi

This comment has been minimized.

Copy link
Member

@tibbi tibbi commented Jan 6, 2020

ye, it is caused by the editor, which is not open source

@darhma

This comment has been minimized.

Copy link

@darhma darhma commented Jan 6, 2020

@tibbi
Are you planning to release a version without photo editor for f-droid?

@tibbi

This comment has been minimized.

Copy link
Member

@tibbi tibbi commented Jan 6, 2020

for now not, we will see later

@IzzySoft

This comment has been minimized.

Copy link

@IzzySoft IzzySoft commented Jan 13, 2020

@tibbi how does closed source comply with GPL? Don't you have license issues that way? What license is the photo editor covered by?

@tibbi

This comment has been minimized.

Copy link
Member

@tibbi tibbi commented Jan 14, 2020

I dont see any problems with it, their license is at https://github.com/imgly/pesdk-android-demo/blob/master/LICENSE.md

@ritzmann

This comment has been minimized.

Copy link

@ritzmann ritzmann commented Jan 14, 2020

"Linking" code under a non-free license into GPL code is trickier than it seems:
https://www.gnu.org/licenses/gpl-faq.en.html#GPLIncompatibleLibs

My understanding is that you would need to alter the GPL license notice as described in the above link and you would need permission from all 102 contributors (according to Github stats) to Simple Gallery to make that license change.

@CryptOwl

This comment has been minimized.

Copy link

@CryptOwl CryptOwl commented Jan 14, 2020

I add my concern that the inclusion of the proprietary library is a bad decision. Communities based around free software have been pushing your apps for years. The pretty well known German privacy blogger Mike Kuketz has been recommending your app for quite some time due to its free software nature: https://www.kuketz-blog.de/empfehlungsecke/#android
I have also been recommending Simple Gallery (Pro) in CryptoParty related material (including hundreds of printed handouts) and other of your apps for years. I will be unable to do this since new versions will no longer bee free software and cannot be built in F-Droid.

Please reconsider this decision.

@klawdhfzasjhaa

This comment has been minimized.

Copy link

@klawdhfzasjhaa klawdhfzasjhaa commented Feb 6, 2020

Additionally, one could argue that the app ist called Simple Gallery, not "feature rich picture editing app". ;) The basic editing options were sufficiant to me.

@floppyD

This comment has been minimized.

Copy link
Contributor

@floppyD floppyD commented Feb 9, 2020

Yeah, I don't think the new editor is worth it. The previous one was fine and "Simple" enough.

@grravity

This comment has been minimized.

Copy link

@grravity grravity commented Feb 11, 2020

+1 to this convo, I really don't see the point in having the editor. Also I agree woth CryptOwl on the proprietary library being a bad decision, I praised the app so hard, but since the addition of the editor I just can't anymore. I love the app so much if it wasn't for this. Maybe keep the f-droid one seperate without the editor and keep pushing updates and all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants
You can’t perform that action at this time.