Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed showing note picker on opening from shortcut (#679) #680

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fixed showing note picker on opening from shortcut (#679) #680

merged 1 commit into from
Aug 30, 2023

Conversation

Aga-C
Copy link
Contributor

@Aga-C Aga-C commented Aug 28, 2023

Fixes #679

The problem occurred for all types of shortcuts, so this fix is for all of them.

Before:

qemu-system-x86_64_lfR4CHi0Vm.mp4

After:

qemu-system-x86_64_5sRs3H8QGP.mp4

@tibbi
Copy link
Contributor

tibbi commented Aug 30, 2023

can you apply it to widgets too?

@Aga-C
Copy link
Contributor Author

Aga-C commented Aug 30, 2023

can you apply it to widgets too?

It works for widgets too.

@tibbi
Copy link
Contributor

tibbi commented Aug 30, 2023

not to me

@Aga-C
Copy link
Contributor Author

Aga-C commented Aug 30, 2023

I've tested both on emulator and real device (with Android 13), and it works for all kinds of widgets and shortcuts. Also, widgets always provide note id via intent, so it should work without any problems. Can you try building the code and testing once again?

@tibbi
Copy link
Contributor

tibbi commented Aug 30, 2023

works now, guess I had to clean the project or whatever... Thanks

@tibbi tibbi merged commit aa41b53 into SimpleMobileTools:master Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launching via shortcut shouldn't open note picker
2 participants