Prevent using archive table if it doesn't exist
#775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes #773
tibbi
reviewed
Oct 3, 2023
| try { | ||
| contentResolver.update(uri, values, selection, selectionArgs) | ||
| } catch (sqliteException: SQLiteException) { | ||
| if (sqliteException.message?.contains("no such column: archived") == true && config.useThreadsArchive) { |
There was a problem hiding this comment.
not sure how reliable is this, we will see
There was a problem hiding this comment.
I was worried about disabling archive on any kind of SQLiteException, especially since that option is hidden to the users, so I tried to make it a bit more specific.
tibbi
reviewed
Oct 3, 2023
app/src/main/kotlin/com/simplemobiletools/smsmessenger/helpers/Config.kt
Outdated
Show resolved
Hide resolved
tibbi
reviewed
Oct 3, 2023
app/src/main/kotlin/com/simplemobiletools/smsmessenger/helpers/Config.kt
Outdated
Show resolved
Hide resolved
tibbi
reviewed
Oct 3, 2023
app/src/main/kotlin/com/simplemobiletools/smsmessenger/helpers/Config.kt
Outdated
Show resolved
Hide resolved
|
ok thanks, should be good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #773