We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type:
I'm going to open a PR:
Description:
Both Chrome and Firefox state that comments are allowed in the manifest: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json https://developer.chrome.com/docs/extensions/mv2/manifest/
Yet, they cause this project to crash.
As far as I can tell, you only read the manifest here: https://github.com/SimplifyJobs/webpack-ext-reloader/blob/master/src/utils/manifest.ts#L11
So it should be pretty simple and not add a lot of overhead to strip the comments there. 🙂
The text was updated successfully, but these errors were encountered:
This makes sense, and I would welcome a PR!
Sorry, something went wrong.
🐛 Use JSON5 to parse manifest.json (closes #216)
437c157
0c4fe86
Damn, I missed that response back in March somehow. Sorry about that! 🙈
(Thanks for taking care of it - should be of help to my former colleagues.)
No branches or pull requests
Type:
I'm going to open a PR:
Description:
Both Chrome and Firefox state that comments are allowed in the manifest:
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json
https://developer.chrome.com/docs/extensions/mv2/manifest/
Yet, they cause this project to crash.
As far as I can tell, you only read the manifest here: https://github.com/SimplifyJobs/webpack-ext-reloader/blob/master/src/utils/manifest.ts#L11
So it should be pretty simple and not add a lot of overhead to strip the comments there. 🙂
The text was updated successfully, but these errors were encountered: