Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support manifest comments #216

Closed
2 of 6 tasks
s-h-a-d-o-w opened this issue Mar 14, 2022 · 2 comments
Closed
2 of 6 tasks

Support manifest comments #216

s-h-a-d-o-w opened this issue Mar 14, 2022 · 2 comments
Labels
status: verified The bug issue was reviewed and is verified to have the problem stated. type: bug A bug.

Comments

@s-h-a-d-o-w
Copy link

Type:

  • bug
  • feature
  • enhancement
  • question

I'm going to open a PR:

  • yes (If you agree that this should be addressed.)
  • no

Description:

Both Chrome and Firefox state that comments are allowed in the manifest:
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json
https://developer.chrome.com/docs/extensions/mv2/manifest/

Yet, they cause this project to crash.

As far as I can tell, you only read the manifest here: https://github.com/SimplifyJobs/webpack-ext-reloader/blob/master/src/utils/manifest.ts#L11

So it should be pretty simple and not add a lot of overhead to strip the comments there. 🙂

@rushilsrivastava rushilsrivastava added type: bug A bug. status: verified The bug issue was reviewed and is verified to have the problem stated. labels Mar 14, 2022
@rushilsrivastava
Copy link
Member

This makes sense, and I would welcome a PR!

@s-h-a-d-o-w
Copy link
Author

Damn, I missed that response back in March somehow. Sorry about that! 🙈

(Thanks for taking care of it - should be of help to my former colleagues.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: verified The bug issue was reviewed and is verified to have the problem stated. type: bug A bug.
Projects
None yet
Development

No branches or pull requests

2 participants