-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working on Firefox : runtime is not defined #90
Comments
Thanks for reporting this. We'll have to take a closer look at this, but can definitely verify this is happening on our end. |
Hey, apologize for the radio silence here. We are looking to push out a new update with all of these fixes. Would you have an example of where you are getting these issues? It seems like we are no longer getting these errors in our workflows as of Firefox 94.0.1. |
Hello, I can confirm that I still face the same issue in Firefox 94.0.1 with my extension (https://github.com/lmichelin/open-github-links-in-ide) Steps to reproduce the issue:
Thanks for your support. |
Ref #90 Signed-off-by: Rushil Srivastava <rushil@simplify.jobs>
* 🐛 Fix firefox browser not being recognized on content scripts Ref #90 Signed-off-by: Rushil Srivastava <rushil@simplify.jobs> * 🚚 Rename all references of old repository Signed-off-by: Rushil Srivastava <rushil@simplify.jobs> * 🧑💻 Updatge sample scripts for better testing on Firefox and Chrome Signed-off-by: Rushil Srivastava <rushil@simplify.jobs>
Sorry for the late response on this, happy to report that this has been fixed and will be shipped in the next version: |
I can confirm that it works, thanks for your support! 🎉 |
Type:
Environment:
I'm going to open a PR:
Description:
I was using webpack 4 and the webpack-extension-reloader package and it was working well on Firefox. I decided to migrate to webpack 5 and to use this library instead of webpack-extension-reloader, but this library is not working on Firefox. The following error is reported by the browser console (Ctrl+Maj+J):
TypeError: runtime is undefined inject.js:1320:18
Thanks for your support.
The text was updated successfully, but these errors were encountered: