Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on Firefox : runtime is not defined #90

Closed
2 of 6 tasks
lmichelin opened this issue Aug 31, 2021 · 5 comments · Fixed by #163
Closed
2 of 6 tasks

Not working on Firefox : runtime is not defined #90

lmichelin opened this issue Aug 31, 2021 · 5 comments · Fixed by #163
Labels
status: verified The bug issue was reviewed and is verified to have the problem stated. type: bug A bug.

Comments

@lmichelin
Copy link
Contributor

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Ubuntu
  • Browser: Firefox 91.0.2
  • Library Version: 1.1.8

I'm going to open a PR:

  • yes
  • no

Description:
I was using webpack 4 and the webpack-extension-reloader package and it was working well on Firefox. I decided to migrate to webpack 5 and to use this library instead of webpack-extension-reloader, but this library is not working on Firefox. The following error is reported by the browser console (Ctrl+Maj+J):

TypeError: runtime is undefined inject.js:1320:18

Thanks for your support.

@rushilsrivastava rushilsrivastava added status: verified The bug issue was reviewed and is verified to have the problem stated. type: bug A bug. labels Sep 1, 2021
@rushilsrivastava
Copy link
Member

Thanks for reporting this. We'll have to take a closer look at this, but can definitely verify this is happening on our end.

@rushilsrivastava
Copy link
Member

Hey, apologize for the radio silence here. We are looking to push out a new update with all of these fixes. Would you have an example of where you are getting these issues?

It seems like we are no longer getting these errors in our workflows as of Firefox 94.0.1.

@lmichelin
Copy link
Contributor Author

Hello, I can confirm that I still face the same issue in Firefox 94.0.1 with my extension (https://github.com/lmichelin/open-github-links-in-ide)

Steps to reproduce the issue:

  • Clone the repository https://github.com/lmichelin/open-github-links-in-ide
  • Run yarn to install the dependencies
  • Run yarn dev to start the development server
  • Launch Firefox
  • Open about:debugging#/runtime/this-firefox
  • Click on Load Temporary Add-on
  • Select the dist/firefox/manifest.json file
  • Open the browser console (Ctrl+Maj+J)
  • Open add tests lmichelin/open-github-links-in-ide#5
  • The following error is logged in the browser console TypeError: runtime is undefined inject.js:1320:18
  • The extension is not working (No IDE icons are injected when hovering on file numbers in comments)

Thanks for your support.

rushilsrivastava added a commit that referenced this issue Jan 24, 2022
Ref #90

Signed-off-by: Rushil Srivastava <rushil@simplify.jobs>
rushilsrivastava added a commit that referenced this issue Jan 24, 2022
* 🐛 Fix firefox browser not being recognized on content scripts

Ref #90

Signed-off-by: Rushil Srivastava <rushil@simplify.jobs>

* 🚚 Rename all references of old repository

Signed-off-by: Rushil Srivastava <rushil@simplify.jobs>

* 🧑‍💻 Updatge sample scripts for better testing on Firefox and Chrome

Signed-off-by: Rushil Srivastava <rushil@simplify.jobs>
@rushilsrivastava
Copy link
Member

Sorry for the late response on this, happy to report that this has been fixed and will be shipped in the next version: v1.1.9.

@lmichelin
Copy link
Contributor Author

I can confirm that it works, thanks for your support! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: verified The bug issue was reviewed and is verified to have the problem stated. type: bug A bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants