stleary#863 improve performance of JSONTokener#nextString

replacing a switch-case statement with few branches by if-else cases
Simulant87 · Mar 5, 2024 · 63625b3 · 63625b3
1 parent f38452a
commit 63625b3
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/src/main/java/org/json/JSONTokener.java b/src/main/java/org/json/JSONTokener.java
@@ -295,12 +295,9 @@ public String nextString(char quote) throws JSONException {
         StringBuilder sb = new StringBuilder();
         for (;;) {
             c = this.next();
-            switch (c) {
-            case 0:
-            case '\n':
-            case '\r':
-                throw this.syntaxError("Unterminated string");
-            case '\\':
+            if (c == quote) {
+                return sb.toString();
+            } else if (c == '\\') {
                 c = this.next();
                 switch (c) {
                 case 'b':
@@ -334,11 +331,9 @@ public String nextString(char quote) throws JSONException {
                 default:
                     throw this.syntaxError("Illegal escape.");
                 }
-                break;
-            default:
-                if (c == quote) {
-                    return sb.toString();
-                }
+            } else if (c == 0 || c == '\n' || c == '\r') {
+                throw this.syntaxError("Unterminated string");
+            } else {
                 sb.append(c);
             }
         }