Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Improve toString performance #863

Closed
Simulant87 opened this issue Feb 22, 2024 · 2 comments
Closed

Enhancement: Improve toString performance #863

Simulant87 opened this issue Feb 22, 2024 · 2 comments

Comments

@Simulant87
Copy link
Contributor

The toString methods of JSONObject and JSONArray are not very fast, mostly because of the usage of StringWriter and the generic code to support an indent, although in the default toString case it is always 0.

You can compare the performance of the library e.g. with this comparison project, which also list the results in a graph:
https://github.com/fabienrenaud/java-json-benchmark?tab=readme-ov-file#users-model

My suggestion is to improve the performance for the default toString method without indent by duplicating by using a StringBuilder instead of a StringWriter.
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Feb 22, 2024
@Simulant87
stleary#863 rewrite toString with StringBuilder for better performance
6c43d22
@Simulant87 Simulant87 mentioned this issue Feb 22, 2024
Closed
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Feb 22, 2024
@Simulant87
stleary#863 increase compiler stack size
97cabf8
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Feb 23, 2024
@Simulant87
stleary#863 use StringBuilderWriter to toString methods
7c7a98d 
resulting in a faster toString generation.
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Feb 23, 2024
@Simulant87
stleary#863 improve formatting
0ff635c
@Simulant87 Simulant87 mentioned this issue Feb 23, 2024
Merged
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Feb 23, 2024
@Simulant87
stleary#863 increase compiler stack size on build pipeline
6660e40
@Simulant87 Simulant87 reopened this Feb 23, 2024
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Feb 24, 2024
@Simulant87
stleary#863 compute initial capacity for StringBuilderWriter
06778bd
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Feb 24, 2024
@Simulant87
stleary#863 add StringBuilderWriter unit test
d672b44
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Feb 24, 2024
@Simulant87
stleary#863 undo wrong optimisation, fixing failing test
e2194bc
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Feb 24, 2024
@Simulant87
stleary#863 reorder instanceof checks by assumed frequency
d878c38
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Feb 25, 2024
@Simulant87
stleary#863 fix changed behaviour of changing order in writeValue wit…
4f456d9 
…h JSONString
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Mar 5, 2024
@Simulant87
stleary#863 improve performance of JSONTokener#nextString
63625b3 
replacing a switch-case statement with few branches
by if-else cases
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Mar 5, 2024
@Simulant87
stleary#863 replace usage of back() method in JSONObject parsing
5407423
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Mar 5, 2024
@Simulant87
stleary#863 replace short switch statements with if-else
c010033
@stleary stleary mentioned this issue Mar 9, 2024
Closed
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Mar 10, 2024
@Simulant87
Revert "stleary#863 increase compiler stack size on build pipeline"
eda0841 
This reverts commit 6660e40.
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Mar 10, 2024
@Simulant87
Revert "stleary#863 replace short switch statements with if-else"
045324a 
This reverts commit c010033.
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Mar 10, 2024
@Simulant87
Revert "stleary#863 replace usage of back() method in JSONObject pars…
a3f15e5 
…ing"

This reverts commit 5407423.
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Mar 10, 2024
@Simulant87
Revert "stleary#863 improve performance of JSONTokener#nextString"
0c5cf18 
This reverts commit 63625b3.
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Mar 10, 2024
@Simulant87
stleary#863 make StringBuilderWriter public and move test
6c35b08
Simulant87 added a commit to Simulant87/JSON-java that referenced this issue Mar 10, 2024
@Simulant87
stleary#863 move instanceof Enum check back to original position
b75da07
@nfaupel
Copy link

nfaupel commented Apr 9, 2024 •
edited
Loading

I think this could be closed due to implementation complete in #867

@stleary
Copy link
Owner

stleary commented Apr 9, 2024

Closing due to implementation completed in #867

@stleary stleary closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stleary @Simulant87 @nfaupel