fix: logging behavior based on verbose and save_logs settings #1169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1167
Updates the Logger class in
pandasai/helpers/logger.py
to respect theverbose
andsave_logs
settings more accurately.__init__
method to conditionally addlogging.StreamHandler(sys.stdout)
only ifverbose
is True, ensuring that logs are not printed to the console whenverbose
is False.log
method to check the_verbose
attribute before logging messages to the console, allowing for more granular control over what gets logged based on the verbosity level.save_logs
setter and getter methods to accurately reflect whether logs are being saved to a file, addressing the issue where logs were saved regardless of thesave_logs
setting.filaname
tofilename
in both the__init__
method and thesave_logs
setter, improving code readability and consistency.For more details, open the Copilot Workspace session.