Update plugin.py #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer twisted seems to have issues with Unicode characters (eg Sliač).
Using function quote from urllib2 seems to fix the issue.
Here is the traceback produced without quote function.
Traceback (most recent call last):
File "/usr/lib/enigma2/python/mytest.py", line 209, in processDelay
self.popCurrent()
File "/usr/lib/enigma2/python/mytest.py", line 278, in popCurrent
self.execBegin(first=False, do_show=do_show)
File "/usr/lib/enigma2/python/mytest.py", line 228, in execBegin
c.show()
File "/usr/lib/enigma2/python/Screens/Screen.py", line 150, in show
File "/usr/lib/enigma2/python/plugin.py", line 322, in get_weather_data
File "/usr/lib/enigma2/python/plugin.py", line 318, in get_xmlfile
File "/usr/lib/python2.7/site-packages/twisted/python/deprecate.py", line 301, in deprecatedFunction
File "/usr/lib/python2.7/site-packages/twisted/web/client.py", line 814, in downloadPage
File "/usr/lib/python2.7/site-packages/twisted/web/client.py", line 742, in _makeGetterFactory
File "/usr/lib/python2.7/site-packages/twisted/web/_newclient.py", line 648, in _ensureValidURI
ValueError: Invalid URI 'http://weather.service.msn.com/data.aspx?weadegreetype=C&culture=sk-SK&weasearchstr=Slia\xc4\x8d&src=outlook'
|
@Sirius0103 any chance to merge commit? |
|
Thanks! |
|
I'm sorry, I did not see the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer twisted seems to have issues with Unicode characters (eg Sliač).
Using function quote from urllib2 seems to fix the issue.
Here is the traceback produced without quote function.
Traceback (most recent call last):
File "/usr/lib/enigma2/python/mytest.py", line 209, in processDelay
self.popCurrent()
File "/usr/lib/enigma2/python/mytest.py", line 278, in popCurrent
self.execBegin(first=False, do_show=do_show)
File "/usr/lib/enigma2/python/mytest.py", line 228, in execBegin
c.show()
File "/usr/lib/enigma2/python/Screens/Screen.py", line 150, in show
File "/usr/lib/enigma2/python/plugin.py", line 322, in get_weather_data
File "/usr/lib/enigma2/python/plugin.py", line 318, in get_xmlfile
File "/usr/lib/python2.7/site-packages/twisted/python/deprecate.py", line 301, in deprecatedFunction
File "/usr/lib/python2.7/site-packages/twisted/web/client.py", line 814, in downloadPage
File "/usr/lib/python2.7/site-packages/twisted/web/client.py", line 742, in _makeGetterFactory
File "/usr/lib/python2.7/site-packages/twisted/web/_newclient.py", line 648, in _ensureValidURI
ValueError: Invalid URI 'http://weather.service.msn.com/data.aspx?weadegreetype=C&culture=sk-SK&weasearchstr=Slia\xc4\x8d&src=outlook'