Scrolling large #132
Merged
Scrolling large #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColumnSet.renderArray() now handles Deferreds Added row buffer to OnDemandGrid to increase perceived performance Fixed row reordering bug in Chrome (_StoreMixin.js)
…-large Conflicts: _StoreMixin.js test/complex_column.html
…so it is only used when explicitly changed) Reverted putting the count property on the preload object instead of the node Revert back to not splitting preload nodes, to keep rows contiguous. Fixed issues with reclaiming loading nodes as distant nodes.
…g-large Conflicts: OnDemandList.js test/complex_column.html
| @@ -57,11 +63,11 @@ return declare([List, _StoreMixin], { | |||
| var rootQuery = true; | |||
| var topPreload = { | |||
| node: put(this.contentNode, "div.dgrid-preload", { | |||
| rowIndex: 0 | |||
| rowIndex: 0, | |||
Conflicts: OnDemandList.js
|
This branch doesn't inject preload nodes in between rows, so I am not sure I understand how there would be an issue with rowIndex incrementation improperly treating a preload node as a single row. |
ghost
pushed a commit
that referenced
this pull request
Apr 12, 2012
Improvements to OnDemandList particularly for large grids
ghost
merged commit 
ghost
mentioned this pull request
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.