Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-forms] File upload validation error #1213

Merged
merged 1 commit into from
Oct 20, 2022
Merged

[sitecore-jss-forms] File upload validation error #1213

merged 1 commit into from
Oct 20, 2022

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Oct 20, 2022 •
edited
Loading

Fix for file upload not returning a validation error when submitting an empty input.

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team October 20, 2022 16:45
ambrauer
ambrauer approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@addy-pathania addy-pathania merged commit d99c773 into dev Oct 20, 2022
@addy-pathania addy-pathania deleted the bugfix/550569-forms-validation branch October 20, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addy-pathania @ambrauer