Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue][Angular] Sitecore service endpoint is not proxied in Connected mode #1465

Merged
merged 7 commits into from
May 4, 2023
Merged

[Vue][Angular] Sitecore service endpoint is not proxied in Connected mode #1465

merged 7 commits into from
May 4, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented May 3, 2023 •
edited
Loading

Description / Motivation

  • Introduced proxy configuration for Angular, Vue starters in case Connected mode is used
  • [Angular] Changed environment*.ts -> environment*.js, since we have to import configuration from the js file

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team May 3, 2023 13:14
addy-pathania
addy-pathania approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍🏼
But could not understand the reason for changing environment file from .ts to .js?

@illiakovalenko
Copy link
Contributor Author

@sc-addypathania Here is import statement that I added, and I can't import ts file into js file

@illiakovalenko illiakovalenko merged commit 24fb0d6 into dev May 4, 2023
@illiakovalenko illiakovalenko deleted the bugfix/578138 branch May 4, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addy-pathania addy-pathania addy-pathania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @addy-pathania