Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[React][Vue]Exception while rendering GraphQL page #900

Merged
merged 3 commits into from
Jan 5, 2022
Merged

[React][Vue]Exception while rendering GraphQL page #900

merged 3 commits into from
Jan 5, 2022

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jan 5, 2022 •
edited
Loading

Description / Motivation

Error is thrown when open /graphql page or click GraphQL <.a.> tag

  • Upgraded @apollo/client, issue is fixed in the latest version
  • Use @apollo/client instead of apollo-client

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@vercel
Copy link

vercel bot commented Jan 5, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/4hokBZamKCtKeh18EHsEtscRHS68
✅ Preview: Failed

[Deployment for 045bc39 failed]

@illiakovalenko illiakovalenko requested a review from a team January 5, 2022 11:04
ambrauer
ambrauer approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ambrauer ambrauer merged commit d14d1dc into dev Jan 5, 2022
@ambrauer ambrauer deleted the bugfix/511597 branch January 5, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer