Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanshikan rules are not seen as testable #73

Closed
niclashedam opened this issue Oct 23, 2018 · 0 comments
Closed

Sanshikan rules are not seen as testable #73

niclashedam opened this issue Oct 23, 2018 · 0 comments
Assignees

Comments

@niclashedam
Copy link
Contributor

Currently, Sanshikan rules are not determined to be testable, as they export a constant as an object with multiple arrow functions. Constants and arrow functions are by themselves not seen as testable, as constants are, well, constant and arrow functions can also be constant in some contexts (see fx. packages/alfa-aria/src/features/body.ts). Since Sanshikan rules should be tested, the isTestable heuristic needs to be extended.

@niclashedam niclashedam self-assigned this Oct 23, 2018
@niclashedam niclashedam added this to To do in ⚙️ Development via automation Oct 23, 2018
niclashedam added a commit that referenced this issue Oct 23, 2018
@niclashedam niclashedam moved this from To do to In progress in ⚙️ Development Oct 23, 2018
⚙️ Development automation moved this from In progress to Done Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
⚙️ Development
  
🏁 Done
Development

No branches or pull requests

1 participant