Skip to content
This repository has been archived by the owner on Feb 22, 2020. It is now read-only.

Added deconstructors to the primitives #26

Merged
merged 4 commits into from
May 8, 2019
Merged

Added deconstructors to the primitives #26

merged 4 commits into from
May 8, 2019

Conversation

synercoder
Copy link
Sponsor Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

I added deconstructors to the primitives. I was trying to use ImageSharp for a project, and when using the mutate function I already had a variable named size.

So then I wanted to use a deconstructor and I tried:

var (width, height) = ctx.GetCurrentSize(); 

This proofed not possible since there were no deconstructors, so I thought I write a few.

With this PR the above code will work, and makes imagesharp a bit more usable :)

@CLAassistant
Copy link

CLAassistant commented May 1, 2019

CLA assistant check
All committers have signed the CLA.

@JimBobSquarePants
Copy link
Member

Will review this tonight.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me. Thanks for your help!

@JimBobSquarePants JimBobSquarePants merged commit 74000ee into SixLabors:master May 8, 2019
@synercoder synercoder deleted the deconstructors branch May 8, 2019 12:45
antonfirsov pushed a commit to SixLabors/ImageSharp that referenced this pull request Jan 19, 2020
…tructors

Added deconstructors to the primitives
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants