Improve ImageSharpMiddleware no-op case's performance #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
I profiled Orchard Core as @sebastienros gave the idea. I saw that ImageSharp was doing some unnecessary processing as part of the pipeline when the request ended to be no-op on ImageSharp's behalf. I tweaked following bits:
ProcessRequest
when actually neededOnParseCommands
when result is discarded