Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Png decoder fix for Issue #1014 #1020

Merged
merged 2 commits into from
Oct 4, 2019

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR fixes an issue when decoding PNG where data would spread over multiple IDAT chunks.

@JimBobSquarePants
Copy link
Member

Oh wow! Amazing! I was so worried about those issues.

Thanks so much for helping out here, it’s really really appreciated!

@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #1020 into master will decrease coverage by <.01%.
The diff coverage is 91.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1020      +/-   ##
==========================================
- Coverage   89.87%   89.87%   -0.01%     
==========================================
  Files        1103     1103              
  Lines       48877    48897      +20     
  Branches     3441     3441              
==========================================
+ Hits        43929    43945      +16     
- Misses       4246     4249       +3     
- Partials      702      703       +1
Impacted Files Coverage Δ
tests/ImageSharp.Tests/TestImages.cs 100% <ø> (ø) ⬆️
...ts/ImageSharp.Tests/Formats/Png/PngDecoderTests.cs 100% <100%> (ø) ⬆️
...c/ImageSharp/Formats/Png/Zlib/ZlibInflateStream.cs 57.33% <83.33%> (-3.78%) ⬇️
...eSharp.Tests/Formats/Png/PngDecoderTests.Chunks.cs 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4fecd5...fdab536. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit 082d7fa into SixLabors:master Oct 4, 2019
@brianpopow
Copy link
Collaborator Author

@JimBobSquarePants maybe at the end of the Issue1014 unit test a image.CompareToOriginal(provider, ImageComparer.Exact); could be added, just to make sure.

@brianpopow brianpopow changed the title WIP: Png decoder fix for Issue #1014 Png decoder fix for Issue #1014 Oct 5, 2019
@antonfirsov
Copy link
Member

Yeah definitely, let's always include validating tests in all PR-s!

@JimBobSquarePants
Copy link
Member

Yes, missed that it wasn’t there in my excitement!

antonfirsov pushed a commit to antonfirsov/ImageSharp that referenced this pull request Nov 11, 2019
@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc1 milestone Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants