Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore StyleCop Warnings as Errors #1664

Merged
merged 3 commits into from Jun 15, 2021
Merged

Conversation

JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Jun 15, 2021

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #1658

See SixLabors/SharedInfrastructure#20 for details.

We needed to be more specific with our settings.

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #1664 (1642a67) into master (5966a2e) will not change coverage.
The diff coverage is 95.65%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1664   +/-   ##
=======================================
  Coverage   84.32%   84.32%           
=======================================
  Files         816      816           
  Lines       35856    35856           
  Branches     4167     4167           
=======================================
  Hits        30235    30235           
  Misses       4799     4799           
  Partials      822      822           
Flag Coverage 螖
unittests 84.32% <95.65%> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
.../Formats/Tiff/Writers/TiffPaletteWriter{TPixel}.cs 97.10% <0.00%> (酶)
...omponents/Encoder/RgbToYCbCrConverterVectorized.cs 97.97% <100.00%> (酶)
...rp/Formats/Jpeg/Components/FastFloatingPointDCT.cs 100.00% <100.00%> (酶)
src/ImageSharp/Formats/Jpeg/JpegEncoderCore.cs 95.16% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5966a2e...1642a67. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit af5d669 into master Jun 15, 2021
@JimBobSquarePants JimBobSquarePants deleted the js/fix-warnings branch June 15, 2021 05:12
Comment on lines -549 to +554
{2BF743D8-2A06-412D-96D7-F448F00C5EA5}.Debug-InnerLoop|Any CPU.ActiveCfg = Debug-InnerLoop|Any CPU
{2BF743D8-2A06-412D-96D7-F448F00C5EA5}.Debug-InnerLoop|Any CPU.Build.0 = Debug-InnerLoop|Any CPU
{2BF743D8-2A06-412D-96D7-F448F00C5EA5}.Debug-InnerLoop|x64.ActiveCfg = Debug-InnerLoop|Any CPU
{2BF743D8-2A06-412D-96D7-F448F00C5EA5}.Debug-InnerLoop|x64.Build.0 = Debug-InnerLoop|Any CPU
{2BF743D8-2A06-412D-96D7-F448F00C5EA5}.Debug-InnerLoop|x86.ActiveCfg = Debug-InnerLoop|Any CPU
{2BF743D8-2A06-412D-96D7-F448F00C5EA5}.Debug-InnerLoop|x86.Build.0 = Debug-InnerLoop|Any CPU
{2BF743D8-2A06-412D-96D7-F448F00C5EA5}.Debug-InnerLoop|Any CPU.ActiveCfg = Debug|Any CPU
{2BF743D8-2A06-412D-96D7-F448F00C5EA5}.Debug-InnerLoop|Any CPU.Build.0 = Debug|Any CPU
{2BF743D8-2A06-412D-96D7-F448F00C5EA5}.Debug-InnerLoop|x64.ActiveCfg = Debug|Any CPU
{2BF743D8-2A06-412D-96D7-F448F00C5EA5}.Debug-InnerLoop|x64.Build.0 = Debug|Any CPU
{2BF743D8-2A06-412D-96D7-F448F00C5EA5}.Debug-InnerLoop|x86.ActiveCfg = Debug|Any CPU
{2BF743D8-2A06-412D-96D7-F448F00C5EA5}.Debug-InnerLoop|x86.Build.0 = Debug|Any CPU
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JimBobSquarePants wouldn't this result in picking wrong project-level configs in VS for the Debug-InnerLoop solution config?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configbuilder is odd. Either way seems to do what we want and this is the default generated when you create and copy settings from existing. I hacked it before and VS get complaining something was wrong if I switched between the two.

@JimBobSquarePants JimBobSquarePants mentioned this pull request Jun 16, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StyleCop warnings no longer fail the build
2 participants